[jira] [Commented] (CASSANDRA-2733) nodetool ring with EC2Snitch, NPE checking for the zone and dc

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045765#comment-13045765 ] 

Jonathan Ellis commented on CASSANDRA-2733:
-------------------------------------------

awsApiCall in the test is unused, should it just be removed or did you mean to add another test using it?

> nodetool ring with EC2Snitch, NPE checking for the zone and dc
> --------------------------------------------------------------
>
>                 Key: CASSANDRA-2733
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2733
>             Project: Cassandra
>          Issue Type: New Feature
>          Components: Contrib
>    Affects Versions: 0.8.0
>         Environment: Cassandra JVM
>            Reporter: Vijay
>            Assignee: Vijay
>            Priority: Minor
>             Fix For: 0.8.1
>
>         Attachments: EC2Snitch-Patch-2733.patch, EC2Snitch-test-2733.patch
>
>
> Existing EC2Snitch... compare is done via == instead of equals() while comparing the IP's... 
> (endpoint == FBUtilities.getLocalAddress())
> It is ok to compare the Object Address as most of the code uses FBU.getLocalAddress() and it returns the same object everywhere... but it breaks nodetool ring.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira