You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/02 21:43:19 UTC
[GitHub] [beam] allenpradeep opened a new pull request #13641: [BEAM-11434]Make SpannerAccessor public
allenpradeep opened a new pull request #13641:
URL: https://github.com/apache/beam/pull/13641
Spanner Accessor was made to package private in an earlier pull request from public. https://github.com/apache/beam/pull/10765
Spanner import/export templates were using some of the public methods from this class. As a result it was required to copy these classes into Spanner templates causing issues.
This patch makes this class public.
R: @nielm @sabhyankar @chamikaramj
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam
.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace | Typescript
--- | --- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay merged pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
aaltay merged pull request #13641:
URL: https://github.com/apache/beam/pull/13641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-765065740
Hi Ahmet,
I need to fix the failing tests. Will do and resend the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-756521963
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-770548933
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-765062357
What is the next action on this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-878757807
Thanks. it looks like the build passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-879259433
Tests are passing, and there is an LGTM. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-756933380
Thanks and i'll fix the testGcpApiSurface test. Looks like the test was modified in the PR which made this class package private.
https://github.com/apache/beam/pull/10765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-765065740
Hi Ahmet,
I need to fix the failing tests. Will do and resend the patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-756902352
Looks like test failure (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest.testGcpApiSurface) is related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
chamikaramj commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-756902352
Looks like test failure (org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest.testGcpApiSurface) is related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-770571067
Run Java PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-765062357
What is the next action on this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-878736728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-756933380
Thanks and i'll fix the testGcpApiSurface test. Looks like the test was modified in the PR which made this class package private.
https://github.com/apache/beam/pull/10765
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-770590020
@chamikaramj - Fixed the org.apache.beam.sdk.io.gcp.GcpApiSurfaceTest.testGcpApiSurface errors due to Spanner changes.
The errors thrown seem to be coming from DataStore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-878655584
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] allenpradeep commented on pull request #13641: [BEAM-11434]Make SpannerAccessor public
Posted by GitBox <gi...@apache.org>.
allenpradeep commented on pull request #13641:
URL: https://github.com/apache/beam/pull/13641#issuecomment-878731313
The "Run Java PreCommit" build failed with warnings.
https://ci-beam.apache.org/job/beam_PreCommit_Java_Commit/18305/java/new/#moduleNameContent
@chamikaramj - Any suggestions regarding the warnings? We have had a customer asking for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org