You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/23 05:53:18 UTC
[GitHub] [dolphinscheduler] EricGao888 opened a new pull request, #12121: [Doc][Improvement] Add instructions for process execution type and data complement
EricGao888 opened a new pull request, #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121
## Purpose of the pull request
* Add instructions for process execution type.
* Add English docs for data complement (backfill).
* This PR closes: #11814
## Brief change log
* Already described above.
## Verify this pull request
* This PR is only doc fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#discussion_r978752500
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -50,6 +50,17 @@ Click the `Save` button, and the "Set DAG chart name" window pops up, as shown i
+### Configure workflow (process) execution type
+
+Click the `Save` button and configure `process execution type` in the pop-up window. There are four process execution types:
+
+- `Parallel`: If there are multiple instances of the same workflow definition, execute the instances in parallel.
+- `Serial Wait`: If there are multiple instances of the same workflow definition, execute the instances in serial.
+- `Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones.
Review Comment:
@caishunfeng Got it, thanks for the explanation. BTW, I've already updated the docs. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#discussion_r978286282
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -50,6 +50,17 @@ Click the `Save` button, and the "Set DAG chart name" window pops up, as shown i
+### Configure workflow (process) execution type
+
+Click the `Save` button and configure `process execution type` in the pop-up window. There are four process execution types:
+
+- `Parallel`: If there are multiple instances of the same workflow definition, execute the instances in parallel.
+- `Serial Wait`: If there are multiple instances of the same workflow definition, execute the instances in serial.
+- `Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones.
Review Comment:
I'm not sure whether I got it correct here. Could u plz help take a look when available? @ruanwenjun @caishunfeng Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#issuecomment-1255943473
@zhongjiajie @ruanwenjun @caishunfeng BTW, I labeled this PR with `3.2.0` milestone. Do we need to cp this to `3.1.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#issuecomment-1256302637
> @zhongjiajie @ruanwenjun @caishunfeng BTW, I labeled this PR with `3.2.0` milestone. Do we need to cp this to `3.1.0`?
I think it's OK to cp to 3.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on code in PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#discussion_r978306256
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -50,6 +50,17 @@ Click the `Save` button, and the "Set DAG chart name" window pops up, as shown i
+### Configure workflow (process) execution type
+
+Click the `Save` button and configure `process execution type` in the pop-up window. There are four process execution types:
+
+- `Parallel`: If there are multiple instances of the same workflow definition, execute the instances in parallel.
+- `Serial Wait`: If there are multiple instances of the same workflow definition, execute the instances in serial.
+- `Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones.
Review Comment:
> `Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones and kill the current running ones.
Just for confirmation, in that case, there will be no instances running for the workflow definition once killing done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#discussion_r978299926
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -50,6 +50,17 @@ Click the `Save` button, and the "Set DAG chart name" window pops up, as shown i
+### Configure workflow (process) execution type
+
+Click the `Save` button and configure `process execution type` in the pop-up window. There are four process execution types:
+
+- `Parallel`: If there are multiple instances of the same workflow definition, execute the instances in parallel.
+- `Serial Wait`: If there are multiple instances of the same workflow definition, execute the instances in serial.
+- `Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones.
Review Comment:
`Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones and kill the current running ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on code in PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#discussion_r978746301
##########
docs/docs/en/guide/project/workflow-definition.md:
##########
@@ -50,6 +50,17 @@ Click the `Save` button, and the "Set DAG chart name" window pops up, as shown i
+### Configure workflow (process) execution type
+
+Click the `Save` button and configure `process execution type` in the pop-up window. There are four process execution types:
+
+- `Parallel`: If there are multiple instances of the same workflow definition, execute the instances in parallel.
+- `Serial Wait`: If there are multiple instances of the same workflow definition, execute the instances in serial.
+- `Serial Discard`: If there are multiple instances of the same workflow definition, discard the later ones.
Review Comment:
> Just for confirmation, in that case, there will be no instances running for the workflow definition once killing done?
Yes, if a new workflow instance ready to run, it will kill all the running instances if serial discard.
see https://github.com/apache/dolphinscheduler/blob/82ddd72e4a2fae8d8926e5ff8ec35600d0483fbc/dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java#L343-L356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121#issuecomment-1256308850
> > @zhongjiajie @ruanwenjun @caishunfeng BTW, I labeled this PR with `3.2.0` milestone. Do we need to cp this to `3.1.0`?
>
> I think it's OK to cp to 3.1.0
Sure, will do once it merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng merged pull request #12121: [Doc][Improvement] Add instructions for process execution type and data complement
Posted by GitBox <gi...@apache.org>.
caishunfeng merged PR #12121:
URL: https://github.com/apache/dolphinscheduler/pull/12121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org