You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/02/08 18:27:53 UTC
[GitHub] lkishalmi commented on a change in pull request #415: [NETBEANS-365] Allow Harness to be more Friendly
lkishalmi commented on a change in pull request #415: [NETBEANS-365] Allow Harness to be more Friendly
URL: https://github.com/apache/incubator-netbeans/pull/415#discussion_r167025816
##########
File path: nbbuild/antsrc/org/netbeans/nbbuild/ParseProjectXml.java
##########
@@ -991,7 +993,16 @@ private String computeClasspath(String myCNB, ModuleListParser modules, Dep[] de
if (!dep.impl && /* #71807 */ dep.run && !recursive && !runtime) {
String friends = attr.getValue("OpenIDE-Module-Friends");
if (friends != null && !Arrays.asList(friends.split(" *, *")).contains(myCNB)) {
- throw new BuildException("The module " + myCNB + " is not a friend of " + depJar, getLocation());
+ String friendIssue = "The module " + myCNB + " is not a friend of " + depJar;
+ if (Boolean.parseBoolean(getProject().getProperty(PROP_FRIENDLY_MODULES))) {
+ log(friendIssue, Project.MSG_WARN);
+ } else {
+ log("The " + depJar.getName() + " is a non-stable API/SPI. It is only available for its friends.", Project.MSG_ERR);
Review comment:
Well I think the module versioning, stable/non-stable/friendliness of the API-s needs a redesign/rethink. However I think that is more feasible after the Apache migration has happened. Right now there is too much going on on the entire codebase.
Though if somebody would like to announce a few API/SPI as stable, I just could only welcome that. I even have a few candidates for that as well...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists