You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by tv...@apache.org on 2021/02/04 07:20:07 UTC

[buildstream] 15/19: fixup! fixup! Move subprocess machinery into a method

This is an automated email from the ASF dual-hosted git repository.

tvb pushed a commit to branch phil/ui-split-refactor
in repository https://gitbox.apache.org/repos/asf/buildstream.git

commit d851dec4e2166291a184cf85fdc474ce1a64448f
Author: Phil Dawson <ph...@codethink.co.uk>
AuthorDate: Fri Jul 5 15:45:00 2019 +0100

    fixup! fixup! Move subprocess machinery into a method
---
 src/buildstream/_stream.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/buildstream/_stream.py b/src/buildstream/_stream.py
index 1de8364..ed83747 100644
--- a/src/buildstream/_stream.py
+++ b/src/buildstream/_stream.py
@@ -106,8 +106,6 @@ class Stream():
     def init(self):
         self._artifacts = self._context.artifactcache
         self._sourcecache = self._context.sourcecache
-        print(Stream.build, Stream.build.__qualname__, Stream.build.__name__, Stream.build.__module__,
-              id(Stream.build))
 
     def run_in_subprocess(self, func, *args, **kwargs):
         print("Args: {}".format([*args]))
@@ -126,7 +124,7 @@ class Stream():
         self._subprocess.start()
 
         # TODO connect signal handlers
-        while self._subprocess.exitcode is not None:
+        while self._subprocess.exitcode is not:
             self._subprocess.join(0.1)
             self._loop()
         print("Stopping loop...")