You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Rakesh Gupta <ra...@gmail.com> on 2024/10/17 14:50:12 UTC
Re: Review Request 75050: RANGER-4777: Improve API /public/v2/api/service-headers to filter services depending on user role
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75050/
-----------------------------------------------------------
(Updated Oct. 17, 2024, 2:50 p.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-4777
https://issues.apache.org/jira/browse/RANGER-4777
Repository: ranger
Description
-------
Need to update the API - "/public/v2/api/service-headers" introduce in RANGER-4533 with below :
The API should be accessible for non-admin users as well. @PreAuthrize annotation can be removed.
Filtering of services depending on user role like done for existing API - "/plugins/services"
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java accf28721
intg/src/test/java/org/apache/ranger/TestRangerClient.java 5120aceae
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2ece2e22a
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java a7726d780
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java 9e1fb13ef
security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 0a0144094
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 3aeda199a
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java be56c487f
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 892414d8d
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java 59cd2a6dc
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 47bb6e9af
Diff: https://reviews.apache.org/r/75050/diff/4/
Changes: https://reviews.apache.org/r/75050/diff/3-4/
Testing
-------
Tested "/public/v2/api/service-headers" API is accessible for non-admin users.
Thanks,
Rakesh Gupta
Re: Review Request 75050: RANGER-4777: Improve API /public/v2/api/service-headers to filter services depending on user role
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75050/#review226980
-----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java
Line 53 (original), 53 (patched)
<https://reviews.apache.org/r/75050/#comment315265>
Changing signature of an existing method/constructor can break clients; please add a new constructor.
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java
Lines 1366 (patched)
<https://reviews.apache.org/r/75050/#comment315266>
Instead of using serviceDef.implClass, consider using serviceHeader.type to determine whether the service is a KMS service.
return EmbeddedServiceDefsUtil.EMBEDDED_SERVICEDEF_KMS_NAME.equals(serviceHeaer.getType()) ? (isKeyAdmin || isAuditorKeyAdmin) : isUser;
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java
Line 94 (original), 94 (patched)
<https://reviews.apache.org/r/75050/#comment315267>
Please update named query 'XXSecurityZoneRefService.findServiceHeaderInfosByZoneId' to return obj.isEnabled.
- Madhan Neethiraj
On Oct. 17, 2024, 2:50 p.m., Rakesh Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75050/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2024, 2:50 p.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4777
> https://issues.apache.org/jira/browse/RANGER-4777
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Need to update the API - "/public/v2/api/service-headers" introduce in RANGER-4533 with below :
>
> The API should be accessible for non-admin users as well. @PreAuthrize annotation can be removed.
> Filtering of services depending on user role like done for existing API - "/plugins/services"
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java accf28721
> intg/src/test/java/org/apache/ranger/TestRangerClient.java 5120aceae
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2ece2e22a
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java a7726d780
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java 9e1fb13ef
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 0a0144094
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 3aeda199a
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java be56c487f
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 892414d8d
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java 59cd2a6dc
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 47bb6e9af
>
>
> Diff: https://reviews.apache.org/r/75050/diff/4/
>
>
> Testing
> -------
>
> Tested "/public/v2/api/service-headers" API is accessible for non-admin users.
>
>
> Thanks,
>
> Rakesh Gupta
>
>
Re: Review Request 75050: RANGER-4777: Improve API /public/v2/api/service-headers to filter services depending on user role
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75050/#review226983
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 18, 2024, 7:06 a.m., Rakesh Gupta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75050/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2024, 7:06 a.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4777
> https://issues.apache.org/jira/browse/RANGER-4777
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Need to update the API - "/public/v2/api/service-headers" introduce in RANGER-4533 with below :
>
> The API should be accessible for non-admin users as well. @PreAuthrize annotation can be removed.
> Filtering of services depending on user role like done for existing API - "/plugins/services"
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java accf28721
> security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2ece2e22a
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java a7726d780
> security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java 9e1fb13ef
> security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 0a0144094
> security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 3aeda199a
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java be56c487f
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 892414d8d
> security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java 59cd2a6dc
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml 47bb6e9af
>
>
> Diff: https://reviews.apache.org/r/75050/diff/5/
>
>
> Testing
> -------
>
> Tested "/public/v2/api/service-headers" API is accessible for non-admin users.
>
>
> Thanks,
>
> Rakesh Gupta
>
>
Re: Review Request 75050: RANGER-4777: Improve API /public/v2/api/service-headers to filter services depending on user role
Posted by Rakesh Gupta <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75050/
-----------------------------------------------------------
(Updated Oct. 18, 2024, 7:06 a.m.)
Review request for ranger, Dineshkumar Yadav, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, sanket shelar, Sailaja Polavarapu, and Velmurugan Periasamy.
Changes
-------
Addressed Review Comments
Bugs: RANGER-4777
https://issues.apache.org/jira/browse/RANGER-4777
Repository: ranger
Description
-------
Need to update the API - "/public/v2/api/service-headers" introduce in RANGER-4533 with below :
The API should be accessible for non-admin users as well. @PreAuthrize annotation can be removed.
Filtering of services depending on user role like done for existing API - "/plugins/services"
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerServiceHeaderInfo.java accf28721
security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java 2ece2e22a
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefServiceDao.java a7726d780
security-admin/src/main/java/org/apache/ranger/db/XXSecurityZoneRefTagServiceDao.java 9e1fb13ef
security-admin/src/main/java/org/apache/ranger/db/XXServiceDao.java 0a0144094
security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java 3aeda199a
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java be56c487f
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIList.java 892414d8d
security-admin/src/main/java/org/apache/ranger/security/context/RangerAPIMapping.java 59cd2a6dc
security-admin/src/main/resources/META-INF/jpa_named_queries.xml 47bb6e9af
Diff: https://reviews.apache.org/r/75050/diff/5/
Changes: https://reviews.apache.org/r/75050/diff/4-5/
Testing
-------
Tested "/public/v2/api/service-headers" API is accessible for non-admin users.
Thanks,
Rakesh Gupta