[GitHub] [iceberg] rymurr commented on a change in pull request #2307: Bump Nessie to version 0.4.0

[GitBox <gi...@apache.org>]

rymurr commented on a change in pull request #2307:
URL: https://github.com/apache/iceberg/pull/2307#discussion_r590269824



##########
File path: build.gradle
##########
@@ -1102,7 +1102,10 @@ project(':iceberg-nessie') {
   quarkusAppRunnerProperties {
     props = ["quarkus.http.test-port": 0]
   }
-  tasks.getByName("quarkus-start").dependsOn("compileTestJava")
+  tasks.getByName("quarkus-start")
+          // This is not doing anything with Docker or building a native image, just a quirk of in Quarkus since 1.10.

Review comment:
       > quirk of in Quarkus 
   
   nit: quirk of Quarkus

##########
File path: nessie/src/test/java/org/apache/iceberg/nessie/BaseTestIceberg.java
##########
@@ -103,7 +103,7 @@ NessieCatalog initCatalog(String ref) {
     NessieCatalog newCatalog = new NessieCatalog();
     newCatalog.setConf(hadoopConfig);
     newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
-        "url", path,
+        "uri", path,

Review comment:
       this can use `CatalogProperties`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org