You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Richard Downer <no...@github.com> on 2017/11/02 20:56:30 UTC
[jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and boot
the official CentOS images from the AWS Marketplace (#1153)
CentOS’ officially-supported AMIs are hosted on the AWS Marketplace. This adds support for those images, recognising the AMI naming convention and ensuring the OS metadata is parsed correctly and the correct SSH login name is used.
JCLOUDS-1351 is fixed, which was a blocker to using these AMIs. Other issues have been resolved so the jclouds detects the correct data needed to populate the node metadata and allow jclouds to connect.
There is no change to the default jclouds configuration and the official CentOS images will not be detected by default. To use these images, you must alter the ami-query properties to include searching the “AWS Marketplace”, which has an owner ID of 679593333241. You must also manually log on to the AWS Marketplace, select your chosen CentOS image, and “subscribe” to it (you can do this by proceeding as if to launch an image, but stopping after you have agreed to the subscription and before launching).
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds/pull/1153
-- Commit Summary --
* JCLOUDS-1351: improve OS Family parsing
* Recognise CentOS images on AWS Marketplace
-- File Changes --
M apis/ec2/src/main/java/org/jclouds/ec2/compute/strategy/EC2PopulateDefaultLoginCredentialsForImageStrategy.java (5)
M compute/src/main/java/org/jclouds/compute/domain/OsFamily.java (38)
M compute/src/main/java/org/jclouds/compute/util/ComputeServiceUtils.java (10)
M providers/aws-ec2/src/main/java/org/jclouds/aws/ec2/compute/strategy/AWSEC2ReviseParsedImage.java (6)
M providers/aws-ec2/src/test/java/org/jclouds/aws/ec2/compute/strategy/AWSEC2ImageParserTest.java (24)
A providers/aws-ec2/src/test/resources/centos_marketplace_images.xml (38)
-- Patch Links --
https://github.com/jclouds/jclouds/pull/1153.patch
https://github.com/jclouds/jclouds/pull/1153.diff
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1153
Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and
boot the official CentOS images from the AWS Marketplace (#1153)
Posted by Ignasi Barrera <no...@github.com>.
Merged to 2.0.x. Thanks again!
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1153#issuecomment-341683558
Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and
boot the official CentOS images from the AWS Marketplace (#1153)
Posted by Ignasi Barrera <no...@github.com>.
Merged to master. Thanks @rdowner! Worth (and safe) to backport to 2.0.x?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1153#issuecomment-341655207
Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and
boot the official CentOS images from the AWS Marketplace (#1153)
Posted by Ignasi Barrera <no...@github.com>.
Closed #1153.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1153#event-1324521329
Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and
boot the official CentOS images from the AWS Marketplace (#1153)
Posted by Richard Downer <no...@github.com>.
Thanks @nacx. There's a chance that a user could be caught out by a change in jclouds behaviour, but these changes should *increase* the accuracy of the metadata (e.g. reporting a specific Linux distribution than simply "Linux"). Inspecting the code, I can't see a case where it would ever decrease the accuracy. Therefore I think it's safe to backport to 2.0.x.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1153#issuecomment-341680062
Re: [jclouds/jclouds] JCLOUDS-1351: fixes to correctly recognise and
boot the official CentOS images from the AWS Marketplace (#1153)
Posted by Ignasi Barrera <no...@github.com>.
nacx approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1153#pullrequestreview-74024311