You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@arrow.apache.org by "Andrew Lamb (Jira)" <ji...@apache.org> on 2021/02/25 18:22:00 UTC

[jira] [Updated] (ARROW-11777) [Rust] impl AsRef for StringBuilder/BinaryBuilder

     [ https://issues.apache.org/jira/browse/ARROW-11777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Lamb updated ARROW-11777:
--------------------------------
    Summary: [Rust] impl AsRef for StringBuilder/BinaryBuilder  (was: [Rust][Arrow] impl AsRef for StringBuilder/BinaryBuilder)

> [Rust] impl AsRef for StringBuilder/BinaryBuilder
> -------------------------------------------------
>
>                 Key: ARROW-11777
>                 URL: https://issues.apache.org/jira/browse/ARROW-11777
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Rust
>            Reporter: Max Meldrum
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The current implementation of Arrow forces the users to pass a reference to the append_value methods of StringBuilder/BinaryBuilder. Whereas it is passed by value for other types of builders.  This patch suggests adding impl AsRef<[u8]> rather than the current &[u8] parameter. 
> Some background for this issue: I have a Rust derive macro which converts the specified struct to Arrow data. This macro assumes everything is passed by value to Arrow, hence the dilemma. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)