[GitHub] [incubator-devlake] e2corporation opened a new pull request, #3666: fix: add optional chain check for null entity name

[GitBox <gi...@apache.org>]

e2corporation opened a new pull request, #3666:
URL: https://github.com/apache/incubator-devlake/pull/3666

   
   - [x] `Fix` Add Optional chain check (`.?`) for null Entity **Name** for `GitHubProject` and `JenkinsJob` Data Models (`this.name`)
   
   
   ### Description
   
   This PR applies an optional chaining check to handle `null` entity **names** when keys are generated by **Transformations Manager**, and the base trait function `getConfiguredEntityId()` is accessed by what are expected to be Entity Objects that are instances of `GitHubProject` and `JenkinsJob`. This fix should have been included with PR for Plugin Registry Phase 1, however it was not detected during code review.
   
   ### Does this close any open issues?
   Closes #3628
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] likyh merged pull request #3666: fix: add optional chain check for null entity name

[GitBox <gi...@apache.org>]

likyh merged PR #3666:
URL: https://github.com/apache/incubator-devlake/pull/3666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org