[GitHub] [spark] yujhe commented on a change in pull request #26807: [SPARK-30181][SQL] Only add string or integral type column to metastore partition filter

[GitBox <gi...@apache.org>]

yujhe commented on a change in pull request #26807: [SPARK-30181][SQL] Only add string or integral type column to metastore partition filter
URL: https://github.com/apache/spark/pull/26807#discussion_r356925348
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
 ##########
 @@ -676,7 +676,9 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
     object ExtractAttribute {
       def unapply(expr: Expression): Option[Attribute] = {
         expr match {
-          case attr: Attribute => Some(attr)
+          case attr: Attribute
+              if attr.dataType == StringType || IntegralType.acceptsType(attr.dataType) =>
 
 Review comment:
   Sounds good, I'll update for that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org