[GitHub] [incubator-iceberg] aokolnychyi commented on a change in pull request #233: Apply Baseline plugin to iceberg-hive

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #233: Apply Baseline plugin to iceberg-hive
URL: https://github.com/apache/incubator-iceberg/pull/233#discussion_r296805218
 
 

 ##########
 File path: hive/src/main/java/org/apache/iceberg/hive/ClientPool.java
 ##########
 @@ -133,7 +131,9 @@ public void close() {
 
     } catch (InterruptedException e) {
       Thread.currentThread().interrupt();
-      LOG.warn("Interrupted while shutting down pool. Some clients may not be closed.");
+      LOG.warn("Interrupted while shutting down pool. Some clients may not be closed.", e);
     }
   }
+
+  protected abstract void close(C client);
 
 Review comment:
   This one might be questionable. Our code style requires overloaded methods to be together. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org