[GitHub] [orc] zabetak commented on a diff in pull request #1421: ORC-1378: [Java] Add slf4j impl to avoid warning message in example module

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on code in PR #1421:
URL: https://github.com/apache/orc/pull/1421#discussion_r1116746349


##########
java/examples/pom.xml:
##########
@@ -53,16 +53,33 @@
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-common</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.hadoop</groupId>
       <artifactId>hadoop-hdfs</artifactId>
       <scope>compile</scope>
+      <exclusions>
+        <exclusion>
+          <groupId>log4j</groupId>
+          <artifactId>log4j</artifactId>
+        </exclusion>
+      </exclusions>
     </dependency>
     <dependency>
       <groupId>org.apache.hive</groupId>
       <artifactId>hive-storage-api</artifactId>
     </dependency>
+
+    <dependency>
+      <groupId>org.slf4j</groupId>
+      <artifactId>slf4j-simple</artifactId>

Review Comment:
   Actually, I meant to change the scope in `java/pom.xml` not here. Log bindings rarely need to be compile dependencies since we don't want projects to be tight into one specific log implementation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org