You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/01 21:24:07 UTC

[GitHub] [iceberg] rdblue commented on pull request #1825: Add timestamp to table definition in Nessie Catalog

rdblue commented on pull request #1825:
URL: https://github.com/apache/iceberg/pull/1825#issuecomment-736829429


   > Too crazy?
   
   Too crazy.
   
   I think that would hit issues with timestamp precision, whether date and time are separated by space or `T`, and zone offsets. How would we interpret `2020-12-1`? Or `2020-12-01 -07:00`?
   
   I prefer strict conversion into times and then adjusting based on precision. If it was a date, then add 1 day, convert to timestamp, and subtract 1 microsecond.
   
   By the way, what time zone are these supposed to be in? Does this need to respect the SQL session time zone?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org