[GitHub] [skywalking-nodejs] kezhenxu94 commented on pull request #33: MongoDB first working version

[GitBox <gi...@apache.org>]

kezhenxu94 commented on pull request #33:
URL: https://github.com/apache/skywalking-nodejs/pull/33#issuecomment-787937346


   > Should I exclude user processing (like the callback or `.then()`) of an incoming stream from the span and just end the span before the user part?
   
   For such kind of operations (user local processing, callback or `.then()`), we can use Local Span (given proper operation name) to represent that local operations and it's acceptable to incur another Exit span in that local span.
   
   > Ok, that bug in the plugin is not so much of a bug but a design issue. It is caused by MongoDB calling back into itself for internal operation using the same user-level API that starts an exit span.
   
   For this particular case, I'm 👍 to your solution in this PR


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org