You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/11 23:07:59 UTC
Review Request 25556: Dropping synchronized from validateIfLocked()
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/
-----------------------------------------------------------
Review request for Aurora and Bill Farner.
Repository: aurora
Description
-------
Dropping synchronized from validateIfLocked()
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41
Diff: https://reviews.apache.org/r/25556/diff/
Testing
-------
right..
Thanks,
Maxim Khutornenko
Re: Review Request 25556: Dropping synchronized from
validateIfLocked()
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/
-----------------------------------------------------------
(Updated Sept. 12, 2014, 12:13 a.m.)
Review request for Aurora and Bill Farner.
Changes
-------
Unit test courtesy of wfarner.
Bugs: AURORA-702
https://issues.apache.org/jira/browse/AURORA-702
Repository: aurora
Description
-------
Dropping synchronized from validateIfLocked()
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41
src/test/java/org/apache/aurora/scheduler/state/LockManagerImplTest.java 791aa6fed7380999ea9257d92d16b69ed89dcea0
Diff: https://reviews.apache.org/r/25556/diff/
Testing
-------
right..
Thanks,
Maxim Khutornenko
Re: Review Request 25556: Dropping synchronized from
validateIfLocked()
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Sept. 11, 2014, 10:45 p.m., Bill Farner wrote:
> > Feel free to merge in this test case if it's to your liking:
> > https://github.com/wfarner/incubator-aurora/commit/a62f794c6052f6abfa53197dede7f6d21f80f4e4
Big thanks for the patch! Updated.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/#review53129
-----------------------------------------------------------
On Sept. 11, 2014, 9:08 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25556/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:08 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-702
> https://issues.apache.org/jira/browse/AURORA-702
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping synchronized from validateIfLocked()
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41
>
> Diff: https://reviews.apache.org/r/25556/diff/
>
>
> Testing
> -------
>
> right..
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25556: Dropping synchronized from
validateIfLocked()
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/#review53129
-----------------------------------------------------------
Feel free to merge in this test case if it's to your liking:
https://github.com/wfarner/incubator-aurora/commit/a62f794c6052f6abfa53197dede7f6d21f80f4e4
- Bill Farner
On Sept. 11, 2014, 9:08 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25556/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:08 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-702
> https://issues.apache.org/jira/browse/AURORA-702
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping synchronized from validateIfLocked()
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41
>
> Diff: https://reviews.apache.org/r/25556/diff/
>
>
> Testing
> -------
>
> right..
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25556: Dropping synchronized from
validateIfLocked()
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/#review53121
-----------------------------------------------------------
Ship it!
Please add a TODO for test coverage. Testing this for regression shouldn't be too hard, but let's get the fix in.
- Bill Farner
On Sept. 11, 2014, 9:08 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25556/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2014, 9:08 p.m.)
>
>
> Review request for Aurora and Bill Farner.
>
>
> Bugs: AURORA-702
> https://issues.apache.org/jira/browse/AURORA-702
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping synchronized from validateIfLocked()
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41
>
> Diff: https://reviews.apache.org/r/25556/diff/
>
>
> Testing
> -------
>
> right..
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 25556: Dropping synchronized from
validateIfLocked()
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25556/
-----------------------------------------------------------
(Updated Sept. 11, 2014, 9:08 p.m.)
Review request for Aurora and Bill Farner.
Bugs: AURORA-702
https://issues.apache.org/jira/browse/AURORA-702
Repository: aurora
Description
-------
Dropping synchronized from validateIfLocked()
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/LockManagerImpl.java 8befecaf4f13c0b890b452bc7b9c0618725b8c41
Diff: https://reviews.apache.org/r/25556/diff/
Testing
-------
right..
Thanks,
Maxim Khutornenko