[GitHub] [iceberg] kbendick commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases

[GitBox <gi...@apache.org>]

kbendick commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812589961



##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
     def table(self):
         return self.transaction_table
 
+    # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
     def check_last_operation_commited(self, operation):

Review comment:
       Wasn't there a second typo? I would include the comment with both, since these sorts of changes in less-strictly typed languages are harder to fix once they get in (assuming that this function is part of a public API, which we can't really control as much in Python).
   
   People will likely pull some code from `python_legacy` while maaking the new API, and definitely in the new python library we don't want the method to be misspelled 🙂 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org