You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/25 13:30:53 UTC
[GitHub] [dubbo] kylixs opened a new pull request #9129: [3.0] Improve resource cleaning
kylixs opened a new pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129
## What is the purpose of the change
* Improve destroy locks of scope model
* Clean Spring context binding when shutdown
* Fix reused global resource dispose
* Fix recreate application when shutdown #9127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a1f411) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.18%`.
> The diff coverage is `84.82%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.61% +0.18%
- Complexity 310 313 +3
============================================
Files 1177 1177
Lines 50733 50863 +130
Branches 7527 7564 +37
============================================
+ Hits 32690 32867 +177
+ Misses 14470 14412 -58
- Partials 3573 3584 +11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `74.61% <50.00%> (-1.15%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `78.82% <82.14%> (-4.76%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `90.00% <90.42%> (-0.55%)` | :arrow_down: |
| ... and [90 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...4a1f411](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (744986f) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4aaad1e6e986ac946097f5b9abc72f04eb08ca5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aaad1e) will **decrease** coverage by `0.26%`.
> The diff coverage is `79.86%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
- Coverage 64.73% 64.46% -0.27%
- Complexity 310 312 +2
============================================
Files 1178 1178
Lines 50707 50750 +43
Branches 7549 7530 -19
============================================
- Hits 32823 32714 -109
- Misses 14311 14443 +132
- Partials 3573 3593 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.15% <84.12%> (-4.78%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `44.03% <100.00%> (+0.07%)` | :arrow_up: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQXBwbGljYXRpb25Nb2RlbC5qYXZh) | `79.02% <100.00%> (-1.75%)` | :arrow_down: |
| ... and [65 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4aaad1e...744986f](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw commented on a change in pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
zrlw commented on a change in pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#discussion_r736051633
##########
File path: dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboSpringInitializer.java
##########
@@ -54,6 +64,42 @@ public static void initialize(BeanDefinitionRegistry registry) {
initContext(context, registry, beanFactory);
}
+ public static boolean remove(BeanDefinitionRegistry registry) {
+ return contextMap.remove(registry) != null;
+ }
+
+ public static boolean remove(ApplicationContext springContext) {
+ List<BeanDefinitionRegistry> removingKeys = new ArrayList<>();
+ for (Map.Entry<BeanDefinitionRegistry, DubboSpringInitContext> entry : contextMap.entrySet()) {
+ DubboSpringInitContext initContext = entry.getValue();
+ if (initContext.getApplicationContext() == springContext ||
+ initContext.getBeanFactory() == springContext.getAutowireCapableBeanFactory() ||
+ initContext.getRegistry() == springContext.getAutowireCapableBeanFactory()
+ ) {
+ removingKeys.add(entry.getKey());
+ }
+ }
+ for (BeanDefinitionRegistry key : removingKeys) {
+ DubboSpringInitContext context = contextMap.remove(key);
+ logger.info("Unbind dubbo module " + getModelName(context.getModuleModel()) + " from spring container: " +
+ ObjectUtils.identityToString(key));
+ }
+ return contextMap.keySet().removeAll(removingKeys);
Review comment:
already removed by DubboSpringInitContext context = contextMap.remove(key) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6325d81) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.40%`.
> The diff coverage is `84.75%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.84% +0.40%
- Complexity 310 313 +3
============================================
Files 1177 1177
Lines 50733 50861 +128
Branches 7527 7563 +36
============================================
+ Hits 32690 32979 +289
+ Misses 14470 14295 -175
- Partials 3573 3587 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `69.23% <ø> (+0.06%)` | :arrow_up: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `75.38% <50.00%> (-0.38%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `78.82% <82.14%> (-4.76%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `89.85% <90.32%> (-0.69%)` | :arrow_down: |
| ... and [86 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...6325d81](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d39429c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4aaad1e6e986ac946097f5b9abc72f04eb08ca5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aaad1e) will **decrease** coverage by `0.01%`.
> The diff coverage is `81.63%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
- Coverage 64.73% 64.71% -0.02%
- Complexity 310 313 +3
============================================
Files 1178 1178
Lines 50707 50789 +82
Branches 7549 7560 +11
============================================
+ Hits 32823 32870 +47
- Misses 14311 14336 +25
- Partials 3573 3583 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.15% <84.12%> (-4.78%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `88.37% <84.84%> (-2.70%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `44.03% <100.00%> (+0.07%)` | :arrow_up: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQXBwbGljYXRpb25Nb2RlbC5qYXZh) | `79.02% <100.00%> (-1.75%)` | :arrow_down: |
| ... and [41 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4aaad1e...d39429c](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] chickenlj merged pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
chickenlj merged pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw commented on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
zrlw commented on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-954450653
```
[INFO] java.lang.NullPointerException
[INFO] at org.apache.dubbo.registry.client.metadata.MetadataUtils.referProxy(MetadataUtils.java:82)
```
NPE if instance.getOrDefaultApplicationModel() return null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49e8c06) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.36%`.
> The diff coverage is `81.90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.79% +0.36%
+ Complexity 310 309 -1
============================================
Files 1177 1177
Lines 50733 50833 +100
Branches 7527 7554 +27
============================================
+ Hits 32690 32938 +248
+ Misses 14470 14306 -164
- Partials 3573 3589 +16
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `69.23% <ø> (+0.06%)` | :arrow_up: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `75.19% <50.00%> (-0.58%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `77.77% <78.26%> (-5.81%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.96% <87.20%> (-2.58%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...49e8c06](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c16e824) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4aaad1e6e986ac946097f5b9abc72f04eb08ca5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aaad1e) will **decrease** coverage by `0.08%`.
> The diff coverage is `82.57%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
- Coverage 64.73% 64.64% -0.09%
- Complexity 310 311 +1
============================================
Files 1178 1178
Lines 50707 50780 +73
Branches 7549 7536 -13
============================================
+ Hits 32823 32825 +2
- Misses 14311 14359 +48
- Partials 3573 3596 +23
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.15% <84.12%> (-4.78%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `88.37% <84.84%> (-2.70%)` | :arrow_down: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQXBwbGljYXRpb25Nb2RlbC5qYXZh) | `79.02% <100.00%> (-1.75%)` | :arrow_down: |
| [...spring/context/DubboDeployApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0RlcGxveUFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `76.59% <100.00%> (+0.50%)` | :arrow_up: |
| [.../apache/dubbo/remoting/transport/CodecSupport.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQ29kZWNTdXBwb3J0LmphdmE=) | `80.30% <100.00%> (+0.30%)` | :arrow_up: |
| [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `57.14% <100.00%> (-14.29%)` | :arrow_down: |
| [...ize/hessian2/dubbo/Hessian2FactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL2R1YmJvL0hlc3NpYW4yRmFjdG9yeUluaXRpYWxpemVyLmphdmE=) | `60.00% <100.00%> (ø)` | |
| ... and [45 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4aaad1e...c16e824](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c16e824) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4aaad1e6e986ac946097f5b9abc72f04eb08ca5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aaad1e) will **decrease** coverage by `0.25%`.
> The diff coverage is `82.57%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
- Coverage 64.73% 64.47% -0.26%
- Complexity 310 311 +1
============================================
Files 1178 1178
Lines 50707 50780 +73
Branches 7549 7536 -13
============================================
- Hits 32823 32742 -81
- Misses 14311 14445 +134
- Partials 3573 3593 +20
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.15% <84.12%> (-4.78%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `88.37% <84.84%> (-2.70%)` | :arrow_down: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQXBwbGljYXRpb25Nb2RlbC5qYXZh) | `79.02% <100.00%> (-1.75%)` | :arrow_down: |
| [...spring/context/DubboDeployApplicationListener.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib0RlcGxveUFwcGxpY2F0aW9uTGlzdGVuZXIuamF2YQ==) | `76.59% <100.00%> (+0.50%)` | :arrow_up: |
| [.../apache/dubbo/remoting/transport/CodecSupport.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQ29kZWNTdXBwb3J0LmphdmE=) | `80.30% <100.00%> (+0.30%)` | :arrow_up: |
| [...ng/transport/dispatcher/WrappedChannelHandler.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvZGlzcGF0Y2hlci9XcmFwcGVkQ2hhbm5lbEhhbmRsZXIuamF2YQ==) | `57.14% <100.00%> (-14.29%)` | :arrow_down: |
| [...ize/hessian2/dubbo/Hessian2FactoryInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL2R1YmJvL0hlc3NpYW4yRmFjdG9yeUluaXRpYWxpemVyLmphdmE=) | `60.00% <100.00%> (ø)` | |
| ... and [51 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4aaad1e...c16e824](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on a change in pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
kylixs commented on a change in pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#discussion_r736501370
##########
File path: dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboSpringInitializer.java
##########
@@ -54,6 +64,42 @@ public static void initialize(BeanDefinitionRegistry registry) {
initContext(context, registry, beanFactory);
}
+ public static boolean remove(BeanDefinitionRegistry registry) {
+ return contextMap.remove(registry) != null;
+ }
+
+ public static boolean remove(ApplicationContext springContext) {
+ List<BeanDefinitionRegistry> removingKeys = new ArrayList<>();
+ for (Map.Entry<BeanDefinitionRegistry, DubboSpringInitContext> entry : contextMap.entrySet()) {
+ DubboSpringInitContext initContext = entry.getValue();
+ if (initContext.getApplicationContext() == springContext ||
+ initContext.getBeanFactory() == springContext.getAutowireCapableBeanFactory() ||
+ initContext.getRegistry() == springContext.getAutowireCapableBeanFactory()
+ ) {
+ removingKeys.add(entry.getKey());
+ }
+ }
+ for (BeanDefinitionRegistry key : removingKeys) {
+ DubboSpringInitContext context = contextMap.remove(key);
+ logger.info("Unbind dubbo module " + getModelName(context.getModuleModel()) + " from spring container: " +
+ ObjectUtils.identityToString(key));
+ }
+ return contextMap.keySet().removeAll(removingKeys);
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6325d81) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.42%`.
> The diff coverage is `84.75%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.85% +0.42%
- Complexity 310 313 +3
============================================
Files 1177 1177
Lines 50733 50861 +128
Branches 7527 7563 +36
============================================
+ Hits 32690 32987 +297
+ Misses 14470 14288 -182
- Partials 3573 3586 +13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `69.23% <ø> (+0.06%)` | :arrow_up: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `75.38% <50.00%> (-0.38%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `78.82% <82.14%> (-4.76%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `89.85% <90.32%> (-0.69%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...6325d81](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d39429c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4aaad1e6e986ac946097f5b9abc72f04eb08ca5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aaad1e) will **decrease** coverage by `0.24%`.
> The diff coverage is `81.63%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
- Coverage 64.73% 64.49% -0.25%
- Complexity 310 312 +2
============================================
Files 1178 1178
Lines 50707 50789 +82
Branches 7549 7537 -12
============================================
- Hits 32823 32754 -69
- Misses 14311 14441 +130
- Partials 3573 3594 +21
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.15% <84.12%> (-4.78%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `88.37% <84.84%> (-2.70%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `44.03% <100.00%> (+0.07%)` | :arrow_up: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQXBwbGljYXRpb25Nb2RlbC5qYXZh) | `79.02% <100.00%> (-1.75%)` | :arrow_down: |
| ... and [55 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4aaad1e...d39429c](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab4501a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.17%`.
> The diff coverage is `82.94%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.60% +0.17%
- Complexity 310 315 +5
============================================
Files 1177 1177
Lines 50733 50850 +117
Branches 7527 7538 +11
============================================
+ Hits 32690 32854 +164
+ Misses 14470 14405 -65
- Partials 3573 3591 +18
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `74.61% <66.66%> (-1.15%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `77.77% <78.26%> (-5.81%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `88.14% <87.50%> (-2.40%)` | :arrow_down: |
| ... and [89 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...ab4501a](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c0f3e09) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.18%`.
> The diff coverage is `82.65%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.62% +0.18%
Complexity 310 310
============================================
Files 1177 1177
Lines 50733 50831 +98
Branches 7527 7553 +26
============================================
+ Hits 32690 32847 +157
+ Misses 14470 14400 -70
- Partials 3573 3584 +11
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `74.66% <50.00%> (-1.10%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `80.24% <86.95%> (-3.34%)` | :arrow_down: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.96% <87.20%> (-2.58%)` | :arrow_down: |
| ... and [79 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...c0f3e09](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] zrlw edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
zrlw edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-954450653
https://github.com/apache/dubbo/runs/4042205535?check_suite_focus=true
```
[INFO] java.lang.NullPointerException
[INFO] at org.apache.dubbo.registry.client.metadata.MetadataUtils.referProxy(MetadataUtils.java:82)
```
NPE if instance.getOrDefaultApplicationModel() return null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49e8c06) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.37%`.
> The diff coverage is `81.90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.81% +0.37%
Complexity 310 310
============================================
Files 1177 1177
Lines 50733 50833 +100
Branches 7527 7554 +27
============================================
+ Hits 32690 32945 +255
+ Misses 14470 14302 -168
- Partials 3573 3586 +13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `69.23% <ø> (+0.06%)` | :arrow_up: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `75.19% <50.00%> (-0.58%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `77.77% <78.26%> (-5.81%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.96% <87.20%> (-2.58%)` | :arrow_down: |
| ... and [83 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...49e8c06](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (49e8c06) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.15%`.
> The diff coverage is `81.90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.59% +0.15%
+ Complexity 310 309 -1
============================================
Files 1177 1177
Lines 50733 50797 +64
Branches 7527 7525 -2
============================================
+ Hits 32690 32810 +120
+ Misses 14470 14397 -73
- Partials 3573 3590 +17
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `74.95% <50.00%> (-0.82%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `77.77% <78.26%> (-5.81%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.96% <87.20%> (-2.58%)` | :arrow_down: |
| ... and [66 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...49e8c06](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ab4501a) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.21%`.
> The diff coverage is `82.94%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.65% +0.21%
- Complexity 310 315 +5
============================================
Files 1177 1177
Lines 50733 50850 +117
Branches 7527 7561 +34
============================================
+ Hits 32690 32875 +185
+ Misses 14470 14393 -77
- Partials 3573 3582 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `74.61% <66.66%> (-1.15%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `77.77% <78.26%> (-5.81%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `88.14% <87.50%> (-2.40%)` | :arrow_down: |
| ... and [87 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...ab4501a](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6325d81) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.20%`.
> The diff coverage is `84.75%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.64% +0.20%
- Complexity 310 313 +3
============================================
Files 1177 1177
Lines 50733 50861 +128
Branches 7527 7563 +36
============================================
+ Hits 32690 32879 +189
+ Misses 14470 14396 -74
- Partials 3573 3586 +13
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `75.38% <50.00%> (-0.38%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `78.82% <82.14%> (-4.76%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `89.85% <90.32%> (-0.69%)` | :arrow_down: |
| ... and [88 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...6325d81](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a1f411) into [3.0](https://codecov.io/gh/apache/dubbo/commit/bee1de553bad322a067d958ac8fab959448b082b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bee1de5) will **increase** coverage by `0.14%`.
> The diff coverage is `84.82%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
+ Coverage 64.43% 64.57% +0.14%
- Complexity 310 312 +2
============================================
Files 1177 1177
Lines 50733 50827 +94
Branches 7527 7535 +8
============================================
+ Hits 32690 32823 +133
+ Misses 14470 14412 -58
- Partials 3573 3592 +19
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/dubbo/config/deploy/DefaultModuleDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdE1vZHVsZURlcGxveWVyLmphdmE=) | `68.77% <ø> (-0.39%)` | :arrow_down: |
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ubbo/config/deploy/DefaultApplicationDeployer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9kZXBsb3kvRGVmYXVsdEFwcGxpY2F0aW9uRGVwbG95ZXIuamF2YQ==) | `74.56% <50.00%> (-1.20%)` | :arrow_down: |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `85.54% <76.66%> (-5.53%)` | :arrow_down: |
| [...in/java/org/apache/dubbo/rpc/model/ScopeModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2NvcGVNb2RlbC5qYXZh) | `78.82% <82.14%> (-4.76%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `90.00% <90.42%> (-0.55%)` | :arrow_down: |
| ... and [68 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [bee1de5...4a1f411](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] kylixs commented on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
kylixs commented on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951912037
Relative issue: https://github.com/apache/dubbo/issues/9079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9129: [3.0] Improve resource cleaning
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9129:
URL: https://github.com/apache/dubbo/pull/9129#issuecomment-951562646
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9129](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d39429c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/4aaad1e6e986ac946097f5b9abc72f04eb08ca5b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4aaad1e) will **decrease** coverage by `0.19%`.
> The diff coverage is `81.63%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9129/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #9129 +/- ##
============================================
- Coverage 64.73% 64.53% -0.20%
- Complexity 310 313 +3
============================================
Files 1178 1178
Lines 50707 50789 +82
Branches 7549 7560 +11
============================================
- Hits 32823 32775 -48
- Misses 14311 14431 +120
- Partials 3573 3583 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/dubbo/registry/client/InstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvSW5zdGFuY2VBZGRyZXNzVVJMLmphdmE=) | `51.40% <0.00%> (-0.25%)` | :arrow_down: |
| [...bo/registry/client/OverrideInstanceAddressURL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvT3ZlcnJpZGVJbnN0YW5jZUFkZHJlc3NVUkwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...bbo/common/resource/GlobalResourcesRepository.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vcmVzb3VyY2UvR2xvYmFsUmVzb3VyY2VzUmVwb3NpdG9yeS5qYXZh) | `69.81% <60.00%> (-5.19%)` | :arrow_down: |
| [...common/serialize/hessian2/Hessian2ObjectInput.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc2VyaWFsaXphdGlvbi9kdWJiby1zZXJpYWxpemF0aW9uLWhlc3NpYW4yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vc2VyaWFsaXplL2hlc3NpYW4yL0hlc3NpYW4yT2JqZWN0SW5wdXQuamF2YQ==) | `51.85% <60.00%> (+1.85%)` | :arrow_up: |
| [...ava/org/apache/dubbo/rpc/model/FrameworkModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvRnJhbWV3b3JrTW9kZWwuamF2YQ==) | `87.15% <84.12%> (-4.78%)` | :arrow_down: |
| [.../config/spring/context/DubboSpringInitializer.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29uZmlnL2R1YmJvLWNvbmZpZy1zcHJpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL2NvbmZpZy9zcHJpbmcvY29udGV4dC9EdWJib1NwcmluZ0luaXRpYWxpemVyLmphdmE=) | `88.37% <84.84%> (-2.70%)` | :arrow_down: |
| [...apache/dubbo/common/config/ConfigurationUtils.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uZmlnL0NvbmZpZ3VyYXRpb25VdGlscy5qYXZh) | `74.60% <85.71%> (+0.61%)` | :arrow_up: |
| [...mon/src/main/java/org/apache/dubbo/common/URL.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vVVJMLmphdmE=) | `44.03% <100.00%> (+0.07%)` | :arrow_up: |
| [.../dubbo/common/utils/ClassLoaderResourceLoader.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NMb2FkZXJSZXNvdXJjZUxvYWRlci5qYXZh) | `69.81% <100.00%> (+0.58%)` | :arrow_up: |
| [...a/org/apache/dubbo/rpc/model/ApplicationModel.java](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvQXBwbGljYXRpb25Nb2RlbC5qYXZh) | `79.02% <100.00%> (-1.75%)` | :arrow_down: |
| ... and [48 more](https://codecov.io/gh/apache/dubbo/pull/9129/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4aaad1e...d39429c](https://codecov.io/gh/apache/dubbo/pull/9129?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org