You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by aa...@apache.org on 2019/04/01 04:52:53 UTC
[hadoop] branch branch-3.1 updated: HADOOP-16220. Add findbugs
ignores for unjustified issues during update to guava to 27.0-jre in
hadoop-project
This is an automated email from the ASF dual-hosted git repository.
aajisaka pushed a commit to branch branch-3.1
in repository https://gitbox.apache.org/repos/asf/hadoop.git
The following commit(s) were added to refs/heads/branch-3.1 by this push:
new f01d592 HADOOP-16220. Add findbugs ignores for unjustified issues during update to guava to 27.0-jre in hadoop-project
f01d592 is described below
commit f01d592f3ba4c85ffc8ff7e5afe22e9fb40e6ef4
Author: Gabor Bota <ga...@cloudera.com>
AuthorDate: Fri Mar 29 17:26:20 2019 +0100
HADOOP-16220. Add findbugs ignores for unjustified issues during update to guava to 27.0-jre in hadoop-project
This closes #665
Signed-off-by: Akira Ajisaka <aa...@apache.org>
(cherry picked from commit 53a86e2b8ecb83b666d4ed223fc270e1a46642c1)
---
.../dev-support/findbugsExcludeFile.xml | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
diff --git a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
index 3b770f3..f9d834e 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
+++ b/hadoop-hdfs-project/hadoop-hdfs/dev-support/findbugsExcludeFile.xml
@@ -185,6 +185,28 @@
<Bug pattern="OS_OPEN_STREAM" />
</Match>
+ <!-- guava 27.0 update: @Nullable is not detected, however it's there -->
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.qjournal.server.Journal" />
+ <Method name="persistPaxosData" />
+ <Bug pattern="NP_NULL_PARAM_DEREF" />
+ </Match>
+
+
+ <!-- guava 27.0 update: @Nullable is not detected, however it's there -->
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.qjournal.server.JournalNode" />
+ <Method name="getLogDir" />
+ <Bug pattern="NP_NULL_PARAM_DEREF" />
+ </Match>
+
+ <!-- guava 27.0 update: redundant nullcheck (assert for not null) -->
+ <Match>
+ <Class name="org.apache.hadoop.hdfs.qjournal.server.JournalNode" />
+ <Method name="getLogDir" />
+ <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE" />
+ </Match>
+
<!-- Don't complain about LocalDatanodeInfo's anonymous class -->
<Match>
<Class name="org.apache.hadoop.hdfs.client.impl.BlockReaderLocal$LocalDatanodeInfo$1" />
---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org