You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/18 09:05:26 UTC
[GitHub] [airflow] potiuk opened a new pull request, #26458: Switch back breeze image regeneration to be non-docker
potiuk opened a new pull request, #26458:
URL: https://github.com/apache/airflow/pull/26458
The change to move image regeneration to docker has been dictated by slightly inconsistent behaviour on various deployment. The idea was that Docker will solve it but ut has not turned out to be true.
Generating images wihtout the need of image is much faster and more portable and we need to look for some other ways of improving the consistency.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #26458: Switch back breeze image regeneration to be non-docker
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #26458:
URL: https://github.com/apache/airflow/pull/26458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26458: Switch back breeze image regeneration to be non-docker
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26458:
URL: https://github.com/apache/airflow/pull/26458#issuecomment-1250226369
One small problem with lack of groups in rich click with the new method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on a diff in pull request #26458: Switch back breeze image regeneration to be non-docker
Posted by GitBox <gi...@apache.org>.
mik-laj commented on code in PR #26458:
URL: https://github.com/apache/airflow/pull/26458#discussion_r973692733
##########
dev/breeze/src/airflow_breeze/commands/setup_commands.py:
##########
@@ -353,16 +353,18 @@ def backup(script_path_file: Path):
BREEZE_IMAGES_DIR = AIRFLOW_SOURCES_ROOT / "images" / "breeze"
BREEZE_INSTALL_DIR = AIRFLOW_SOURCES_ROOT / "dev" / "breeze"
BREEZE_SOURCES_DIR = BREEZE_INSTALL_DIR / "src"
+COMMAND_HASH_FILE_PATH = BREEZE_IMAGES_DIR / "output-commands-hash.txt"
def get_commands() -> list[str]:
results = []
- content = (BREEZE_IMAGES_DIR / "output-commands-hash.txt").read_text()
- for line in content.splitlines():
- strip_line = line.strip()
- if strip_line.strip() == '' or strip_line.startswith("#"):
- continue
- results.append(':'.join(strip_line.split(":")[:-1]))
+ if COMMAND_HASH_FILE_PATH.exists():
+ content = COMMAND_HASH_FILE_PATH.read_text()
+ for line in content.splitlines():
+ strip_line = line.strip()
+ if strip_line.strip() == '' or strip_line.startswith("#"):
Review Comment:
```suggestion
if strip_line == '' or strip_line.startswith("#"):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #26458: Switch back breeze image regeneration to be non-docker
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #26458:
URL: https://github.com/apache/airflow/pull/26458#issuecomment-1250228456
Now it's better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org