[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4531: [BUG] Tablet is not readable and delete handler report -1903 error, when condition value contains \n

[GitBox <gi...@apache.org>]

wutiangan commented on a change in pull request #4531:
URL: https://github.com/apache/incubator-doris/pull/4531#discussion_r482933055



##########
File path: be/src/olap/delete_handler.cpp
##########
@@ -199,7 +199,7 @@ bool DeleteHandler::_parse_condition(const std::string& condition_str, TConditio
     try {
         // Condition string format
         const char* const CONDITION_STR_PATTERN =
-                R"((\w+)\s*((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>=)|(?:<=)|(?:\*=)|(?:IS))\s*((?:[\S ]+)?))";
+                R"((\w+)\s*((?:=)|(?:!=)|(?:>>)|(?:<<)|(?:>=)|(?:<=)|(?:\*=)|(?:IS))\s*((?:[\r\n\t\S ]+)?))";

Review comment:
       why not change \r\n\t to \s?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org