You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by dilipbiswal <gi...@git.apache.org> on 2018/08/11 18:56:07 UTC
[GitHub] spark pull request #22080: [SPARK-25092] Add RewriteExceptAll and RewriteInt...
GitHub user dilipbiswal opened a pull request:
https://github.com/apache/spark/pull/22080
[SPARK-25092] Add RewriteExceptAll and RewriteIntersectAll in the list of nonExcludableRules
## What changes were proposed in this pull request?
Add RewriteExceptAll and RewriteIntersectAll in the list of nonExcludableRules as the rewrites are essential for the functioning of EXCEPT ALL and INTERSECT ALL feature.
## How was this patch tested?
Added test in OptimizerRuleExclusionSuite.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dilipbiswal/spark exceptall_rewrite_exclusion
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22080.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22080
----
commit a13150b186a1be3e5811c40814c5949da8e113ca
Author: Dilip Biswal <db...@...>
Date: 2018-08-11T18:53:36Z
[SPARK-25092] Add RewriteExceptAll and RewriteIntersectAll in the list of nonExcludableRules
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22080
**[Test build #94625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94625/testReport)** for PR 22080 at commit [`a13150b`](https://github.com/apache/spark/commit/a13150b186a1be3e5811c40814c5949da8e113ca).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22080: [SPARK-25092] Add RewriteExceptAll and RewriteInt...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22080
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22080
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/2085/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22080
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22080
**[Test build #94625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/94625/testReport)** for PR 22080 at commit [`a13150b`](https://github.com/apache/spark/commit/a13150b186a1be3e5811c40814c5949da8e113ca).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22080
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/94625/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22080: [SPARK-25092] Add RewriteExceptAll and RewriteInt...
Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22080#discussion_r209434833
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala ---
@@ -135,7 +135,7 @@ abstract class Optimizer(sessionCatalog: SessionCatalog)
Batch("Subquery", Once,
OptimizeSubqueries) ::
Batch("Replace Operators", fixedPoint,
- RewriteExcepAll,
+ RewriteExceptAll,
--- End diff --
@gatorsmile Fixing a typeo here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by dilipbiswal <gi...@git.apache.org>.
Github user dilipbiswal commented on the issue:
https://github.com/apache/spark/pull/22080
Thanks a lot @gatorsmile
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22080: [SPARK-25092] Add RewriteExceptAll and RewriteIntersectA...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22080
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org