You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by PRAGYA MITTAL <mi...@gmail.com> on 2015/08/13 22:27:59 UTC

Review Request 37444: CrossEntityValidations contains incorrect validations

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37444/
-----------------------------------------------------------

Review request for Falcon.


Bugs: Falcon-1398
    https://issues.apache.org/jira/browse/Falcon-1398


Repository: falcon-git


Description
-------

(instEnd.after(feedEnd)) validation is applied twice for different error messages in CrossEntityValidations.java


Diffs
-----

  common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java 7a01d1e 
  common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 8783081 

Diff: https://reviews.apache.org/r/37444/diff/


Testing
-------

Unit test added


Thanks,

PRAGYA MITTAL

Re: Review Request 37444: CrossEntityValidations contains incorrect validations

Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37444/#review95368
-----------------------------------------------------------

Ship it!


Ship It!

- Ajay Yadava


On Aug. 13, 2015, 8:27 p.m., PRAGYA MITTAL wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37444/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2015, 8:27 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: Falcon-1398
>     https://issues.apache.org/jira/browse/Falcon-1398
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> (instEnd.after(feedEnd)) validation is applied twice for different error messages in CrossEntityValidations.java
> 
> 
> Diffs
> -----
> 
>   common/src/main/java/org/apache/falcon/entity/parser/CrossEntityValidations.java 7a01d1e 
>   common/src/test/java/org/apache/falcon/entity/parser/ProcessEntityParserTest.java 8783081 
> 
> Diff: https://reviews.apache.org/r/37444/diff/
> 
> 
> Testing
> -------
> 
> Unit test added
> 
> 
> Thanks,
> 
> PRAGYA MITTAL
> 
>