[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2776: [Feature] Support Single Sign-On (SSO)

["wolfboys (via GitHub)" <gi...@apache.org>]

wolfboys commented on code in PR #2776:
URL: https://github.com/apache/incubator-streampark/pull/2776#discussion_r1225749970


##########
streampark-console/streampark-console-service/src/main/java/org/apache/streampark/console/system/security/impl/AuthenticatorImpl.java:
##########
@@ -47,8 +47,13 @@ public User authenticate(String username, String password, String loginType) thr
 
     if (loginTypeEnum.equals(LoginType.PASSWORD)) {

Review Comment:
   We can use switch...case instead of if...else



##########
streampark-console/streampark-console-webapp/src/api/system/user.ts:
##########
@@ -44,6 +44,7 @@ enum Api {
   INIT_TEAM = '/user/initTeam',
   APP_OWNERS = '/user/appOwners',
   TransferUserResource = '/user/transferResource',
+  PAC4J_TOKEN = '/sso/token',

Review Comment:
   How about rename PAC4J_TOKEN to SSO_THKEN



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org