You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Joseph Witt (JIRA)" <ji...@apache.org> on 2016/11/01 12:37:58 UTC

[jira] [Comment Edited] (NIFI-2971) bcprov and commons-lang usage in application classloader

    [ https://issues.apache.org/jira/browse/NIFI-2971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15625313#comment-15625313 ] 

Joseph Witt edited comment on NIFI-2971 at 11/1/16 12:37 PM:
-------------------------------------------------------------

In application classloader (/lib)
TODAY
./bcprov-jdk15on-1.54.jar
./commons-lang3-3.4.jar
./jcl-over-slf4j-1.7.12.jar
./jul-to-slf4j-1.7.12.jar
./log4j-over-slf4j-1.7.12.jar
./logback-classic-1.1.3.jar
./logback-core-1.1.3.jar
./nifi-api-1.1.0-SNAPSHOT.jar
./nifi-documentation-1.1.0-SNAPSHOT.jar
./nifi-framework-api-1.1.0-SNAPSHOT.jar
./nifi-nar-utils-1.1.0-SNAPSHOT.jar
./nifi-properties-1.1.0-SNAPSHOT.jar
./nifi-properties-loader-1.1.0-SNAPSHOT.jar
./nifi-runtime-1.1.0-SNAPSHOT.jar
./slf4j-api-1.7.12.jar

NEXT

./jcl-over-slf4j-1.7.12.jar
./jul-to-slf4j-1.7.12.jar
./log4j-over-slf4j-1.7.12.jar
./logback-classic-1.1.3.jar
./logback-core-1.1.3.jar
./slf4j-api-1.7.12.jar
./nifi-api-1.1.0-SNAPSHOT.jar
./nifi-runtime-1.1.0-SNAPSHOT.jar


UNDER SOME LAUNCHER NAR:
----
./bcprov-jdk15on-1.54.jar
./commons-lang3-3.4.jar
./nifi-documentation-1.1.0-SNAPSHOT.jar
./nifi-framework-api-1.1.0-SNAPSHOT.jar
./nifi-properties-1.1.0-SNAPSHOT.jar  (This might need to be on root?)
./nifi-properties-loader-1.1.0-SNAPSHOT.jar
./nifi-nar-utils-1.1.0-SNAPSHOT.jar

The difference:
- nifi-runtime causes 'nifi-launcher.nar' to get invoked which creates the properties/does decrypt as needed/loads all nars...



was (Author: joewitt):
In application classloader (/lib)
TODAY
./bcprov-jdk15on-1.54.jar
./commons-lang3-3.4.jar
./jcl-over-slf4j-1.7.12.jar
./jul-to-slf4j-1.7.12.jar
./log4j-over-slf4j-1.7.12.jar
./logback-classic-1.1.3.jar
./logback-core-1.1.3.jar
./nifi-api-1.1.0-SNAPSHOT.jar
./nifi-documentation-1.1.0-SNAPSHOT.jar
./nifi-framework-api-1.1.0-SNAPSHOT.jar
./nifi-properties-1.1.0-SNAPSHOT.jar
./nifi-properties-loader-1.1.0-SNAPSHOT.jar
./nifi-runtime-1.1.0-SNAPSHOT.jar
./slf4j-api-1.7.12.jar

NEXT

./jcl-over-slf4j-1.7.12.jar
./jul-to-slf4j-1.7.12.jar
./log4j-over-slf4j-1.7.12.jar
./logback-classic-1.1.3.jar
./logback-core-1.1.3.jar
./slf4j-api-1.7.12.jar
./nifi-api-1.1.0-SNAPSHOT.jar
./nifi-runtime-1.1.0-SNAPSHOT.jar


UNDER SOME LAUNCHER NAR:
----
./bcprov-jdk15on-1.54.jar
./commons-lang3-3.4.jar
./nifi-documentation-1.1.0-SNAPSHOT.jar
./nifi-framework-api-1.1.0-SNAPSHOT.jar
./nifi-properties-1.1.0-SNAPSHOT.jar  (This might need to be on root?)
./nifi-properties-loader-1.1.0-SNAPSHOT.jar

The difference:
- nifi-runtime causes 'nifi-launcher.nar' to get invoked which creates the properties/does decrypt as needed/loads all nars...


> bcprov and commons-lang usage in application classloader
> --------------------------------------------------------
>
>                 Key: NIFI-2971
>                 URL: https://issues.apache.org/jira/browse/NIFI-2971
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework, Tools and Build
>    Affects Versions: 1.0.0
>            Reporter: Joseph Witt
>            Assignee: Joseph Witt
>            Priority: Blocker
>             Fix For: 1.1.0
>
>
> In reviewing NIFI-2954 it was noticed that the work in NIFI-1831 led to bcprov and commons-lang3 entering the root application classloader which pollutes all classloaders.  The only things that should be in the root classloader are logging libraries, the nifi api, and a way to bootstrap the application.
> These dependencies need to get moved into the nar and executed via the nifi startup routine



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)