You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/07/30 14:44:15 UTC
[GitHub] [skywalking-rust] jmjoy opened a new pull request, #38: Switch to use nightly rustfmt.
jmjoy opened a new pull request, #38:
URL: https://github.com/apache/skywalking-rust/pull/38
The stable `rustfmt` is too weak, so switch to use the nightly `rustfmt` and add some useful options in `.rustfmt.toml`, such as merge imports and format comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] wu-sheng commented on pull request #38: Switch to use nightly rustfmt.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #38:
URL: https://github.com/apache/skywalking-rust/pull/38#issuecomment-1200213516
Couldn't nightly build make a yesterday passed CI fails today?
We usually recommend lock version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy commented on pull request #38: Switch to use nightly rustfmt.
Posted by GitBox <gi...@apache.org>.
jmjoy commented on PR #38:
URL: https://github.com/apache/skywalking-rust/pull/38#issuecomment-1200228123
Good idea, I have lock the nightly version to `nightly-2022-07-30` in CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] jmjoy merged pull request #38: Switch to use nightly rustfmt.
Posted by GitBox <gi...@apache.org>.
jmjoy merged PR #38:
URL: https://github.com/apache/skywalking-rust/pull/38
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-rust] codecov-commenter commented on pull request #38: Switch to use nightly rustfmt.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #38:
URL: https://github.com/apache/skywalking-rust/pull/38#issuecomment-1200181161
# [Codecov](https://codecov.io/gh/apache/skywalking-rust/pull/38?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#38](https://codecov.io/gh/apache/skywalking-rust/pull/38?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b40c6c4) into [master](https://codecov.io/gh/apache/skywalking-rust/commit/9f777ed76c816abd118f43c5a5a218f8c4b2ed3c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9f777ed) will **increase** coverage by `4.22%`.
> The diff coverage is `50.66%`.
```diff
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
+ Coverage 38.88% 43.11% +4.22%
==========================================
Files 13 14 +1
Lines 306 385 +79
==========================================
+ Hits 119 166 +47
- Misses 187 219 +32
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking-rust/pull/38?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/context/propagation/context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvcHJvcGFnYXRpb24vY29udGV4dC5ycw==) | `100.00% <ø> (ø)` | |
| [src/context/propagation/encoder.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvcHJvcGFnYXRpb24vZW5jb2Rlci5ycw==) | `100.00% <ø> (ø)` | |
| [src/context/span.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvc3Bhbi5ycw==) | `0.00% <ø> (ø)` | |
| [src/context/trace\_context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvdHJhY2VfY29udGV4dC5ycw==) | `21.08% <ø> (ø)` | |
| [src/reporter/grpc.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JlcG9ydGVyL2dycGMucnM=) | `0.00% <0.00%> (ø)` | |
| [tests/trace\_context.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvdHJhY2VfY29udGV4dC5ycw==) | `0.00% <ø> (ø)` | |
| [src/reporter/log.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JlcG9ydGVyL2xvZy5ycw==) | `21.05% <23.52%> (+21.05%)` | :arrow_up: |
| [src/context/tracer.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL2NvbnRleHQvdHJhY2VyLnJz) | `57.29% <57.40%> (+16.11%)` | :arrow_up: |
| [src/reporter/mod.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3JlcG9ydGVyL21vZC5ycw==) | `100.00% <100.00%> (ø)` | |
| [tests/propagation.rs](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdHMvcHJvcGFnYXRpb24ucnM=) | `100.00% <100.00%> (ø)` | |
| ... and [1 more](https://codecov.io/gh/apache/skywalking-rust/pull/38/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org