You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/26 06:46:12 UTC
[GitHub] [echarts] wangguisong opened a new pull request, #16943: feat(LineDraw):series-lines support the effect animation go back
wangguisong opened a new pull request, #16943:
URL: https://github.com/apache/echarts/pull/16943
<!-- Please fill in the following information to help us review your PR more efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [x] new feature
- [ ] others
### What does this PR do?
add the effect.goback property in series-lines to enable the effect animation can go back to the starting point after reaching the destination. it`s necessary to indicates a round trip flight.
### Fixed issues
<!--
- #xxxx: ...
-->
## Details
### Before: What was the problem?
<!-- DESCRIBE THE BUG OR REQUIREMENT HERE. -->
the effect animation in series-lines is one-way, can not indicates a round trip flight.
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->

### After: How is it fixed in this PR?
<!-- THE RESULT AFTER FIXING AND A SIMPLE EXPLANATION ABOUT HOW IT IS FIXED. -->
add the effect.goback property in series-lines to enable the effect animation can go back
<!-- ADD SCREENSHOT HERE IF APPLICABLE. -->

## Misc
<!-- ADD RELATED ISSUE ID WHEN APPLICABLE -->
- [ ] The API has been changed (apache/echarts-doc#xxx).
- [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
### Related test cases or examples to use the new APIs
N.A.
## Others
### Merging options
- [ ] Please squash the commits into a single one when merging.
### Other information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] Ovilia commented on pull request #16943: feat(LineDraw):series-lines support the effect animation go back
Posted by GitBox <gi...@apache.org>.
Ovilia commented on PR #16943:
URL: https://github.com/apache/echarts/pull/16943#issuecomment-1233692484
This PR seems to be released in 5.3.3 but is missing from the [5.3.3 changelog](https://github.com/apache/echarts/releases/tag/5.3.3).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16943: feat(LineDraw):series-lines support the effect animation go back
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16943:
URL: https://github.com/apache/echarts/pull/16943#issuecomment-1110447620
Congratulations! Your PR has been merged. Thanks for your contribution! π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang merged pull request #16943: feat(LineDraw):series-lines support the effect animation go back
Posted by GitBox <gi...@apache.org>.
pissang merged PR #16943:
URL: https://github.com/apache/echarts/pull/16943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] pissang commented on pull request #16943: feat(LineDraw):series-lines support the effect animation go back
Posted by GitBox <gi...@apache.org>.
pissang commented on PR #16943:
URL: https://github.com/apache/echarts/pull/16943#issuecomment-1109434105
Looks great! Could we rename the option from `goback` to `roundTrip` to be more meaningful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] echarts-bot[bot] commented on pull request #16943: feat(LineDraw):series-lines support the effect animation go back
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on PR #16943:
URL: https://github.com/apache/echarts/pull/16943#issuecomment-1109410906
Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [echarts] wangguisong commented on pull request #16943: feat(LineDraw):series-lines support the effect animation go back
Posted by GitBox <gi...@apache.org>.
wangguisong commented on PR #16943:
URL: https://github.com/apache/echarts/pull/16943#issuecomment-1109438890
> Wow looks great! Could we rename the option from `goback` to `roundTrip` to be more meaningful?
yes, of cause
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
Re: [PR] feat(LineDraw):series-lines support the effect animation go back [echarts]
Posted by "cr0032 (via GitHub)" <gi...@apache.org>.
cr0032 commented on PR #16943:
URL: https://github.com/apache/echarts/pull/16943#issuecomment-3139225548
θ§£ε³δΊε
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org