You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/21 19:53:19 UTC

[GitHub] [spark] eejbyfeldt commented on pull request #34043: [SPARK-36782][CORE] Avoid blocking dispatcher-BlockManagerMaster during UpdateBlockInfo

eejbyfeldt commented on pull request #34043:
URL: https://github.com/apache/spark/pull/34043#issuecomment-924334388


   > This is going to make analysis/evolution of the code more complex, so I want to understand better why are we doing this ? What is the current issue/bottleneck and how much of it is mitigated by this change ?
   
   The goal is to fix the deadlock that is described in detail in [SPARK-36782](https://issues.apache.org/jira/browse/SPARK-36782). From our testing this deadlock is common enough meaning that we can not use the decommission features introduced in 3.1.1, since when the deadlock happens the driver does not seem to recover and the spark job en up failing. The patch should remove the possibility of this deadlock by making the `BlockManagerMasterEndpoint` not block when responding to calls with `UpdateBlockInfo`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org