You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/07/02 13:30:02 UTC
[GitHub] [airflow] potiuk opened a new pull request #16776: Switches completely to ghcr.io for development chaing
potiuk opened a new pull request #16776:
URL: https://github.com/apache/airflow/pull/16776
This PR removes the legacy GitHhub Packages and switches Breeze
to use the new ghcr.io public images, which simplifies the
CI architecture and scripts as well as allows us to remove
the CI images of airflow stored in DockerHub
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #16776: Remove legacy GitHub Packages
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #16776:
URL: https://github.com/apache/airflow/pull/16776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16776: Remove legacy GitHub Packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16776:
URL: https://github.com/apache/airflow/pull/16776#issuecomment-873076409
Looks like we are good to merge this one. The `ghcr.io` switch seems successful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16776: Remove legacy GitHub Packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16776:
URL: https://github.com/apache/airflow/pull/16776#issuecomment-873574234
> Can’t say I understand some of the bash stuff but as far a I can tell this is good to merge.
Yeah. Once we simplify some of that I hope we can finally rewrite it in Python: #12282.
This image building and caching done efficiently for development will now be much easier. Some of the complexity I am removing now was because we used both GitHub Packages (For CI) and DockerHub (for Breeze). That was because we did not want to have additional authentication for DockerHub pushing images from CI (and we ere afraid it won't handle the per-build CI images we have). On the other hand, GitHub Packages did not have the option of "Public" images. Now with `ghcr.io` which was promoted to GA recently, we have both - built-in authentication using `GITHUB_TOKEN` and public images, so we can finally switch I think.
I will start gradually replacing parts of the bash scripts with Python soon I think (and invite others to help)
With #16780 we are switching Breeze completely to `ghcr.io` as well and then managing of images becomes much simpler, it did not make much sense to rewrite all the complexity in Python (even in Python it would be equally complex).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #16776: Remove legacy GitHub Packages
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #16776:
URL: https://github.com/apache/airflow/pull/16776#issuecomment-873469576
Good to go this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16776: Remove legacy GitHub Packages
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16776:
URL: https://github.com/apache/airflow/pull/16776#issuecomment-873571019
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org