You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/26 06:39:00 UTC

[GitHub] [incubator-devlake] abeizn opened a new pull request, #3190: fix: type filed is nil in cicd_task table by jenkins-dora union plugin

abeizn opened a new pull request, #3190:
URL: https://github.com/apache/incubator-devlake/pull/3190

   ### ⚠️ Pre Checklist
   
   > Please complete _ALL_ items in this checklist, and remove before submitting
   
   - [ ] I have read through the [Contributing Documentation](https://devlake.apache.org/community/).
   - [ ] I have added relevant tests.
   - [ ] I have added relevant documentation.
   - [ ] I will add labels to the PR, such as `pr-type/bug-fix`, `pr-type/feature-development`, etc.
   
   
   
   # Summary
   fix: type filed is nil in cicd_task table by jenkins-dora union plugin
   
   ### Does this close any open issues?
   related to #3172 
   
   ### Screenshots
   Include any relevant screenshots here.
   
   ### Other Information
   Any other information that is important to this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 merged pull request #3190: fix: type filed is nil in cicd_task table by jenkins-dora union plugin

Posted by GitBox <gi...@apache.org>.
warren830 merged PR #3190:
URL: https://github.com/apache/incubator-devlake/pull/3190


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3190: fix: type filed is nil in cicd_task table by jenkins-dora union plugin

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3190:
URL: https://github.com/apache/incubator-devlake/pull/3190#discussion_r979621995


##########
plugins/dora/tasks/cicd_task_env_enricher.go:
##########
@@ -70,7 +70,7 @@ func EnrichTasksEnv(taskCtx core.SubTaskContext) (err errors.Error) {
 	} else {
 		cursor, err = db.Cursor(
 			dal.From(&devops.CICDTask{}),
-			dal.Join("left join cicd_pipeline_commits cpr on cpr.repo_id != '' and cicd_tasks.pipeline_id = cpr.pipeline_id "),
+			dal.Join("left join cicd_pipeline_commits cpr on cpr.repo_id = '' and cicd_tasks.pipeline_id = cpr.pipeline_id "),

Review Comment:
   I think we should filter cicd tasks by dataSource



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3190: fix: type filed is nil in cicd_task table by jenkins-dora union plugin

Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3190:
URL: https://github.com/apache/incubator-devlake/pull/3190#discussion_r979622899


##########
plugins/dora/tasks/cicd_task_env_enricher.go:
##########
@@ -70,7 +70,7 @@ func EnrichTasksEnv(taskCtx core.SubTaskContext) (err errors.Error) {
 	} else {
 		cursor, err = db.Cursor(
 			dal.From(&devops.CICDTask{}),
-			dal.Join("left join cicd_pipeline_commits cpr on cpr.repo_id != '' and cicd_tasks.pipeline_id = cpr.pipeline_id "),
+			dal.Join("left join cicd_pipeline_commits cpr on cpr.repo_id = '' and cicd_tasks.pipeline_id = cpr.pipeline_id "),

Review Comment:
   I think we should filter cicd tasks by dataSource



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org