You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/04/14 14:42:06 UTC

[GitHub] [incubator-yunikorn-k8shim] yuchaoran2011 commented on a change in pull request #253: [YUNIKORN-558] Integration with Spark K8s Operator

yuchaoran2011 commented on a change in pull request #253:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/253#discussion_r613310459



##########
File path: pkg/cache/placeholder_manager.go
##########
@@ -46,10 +47,13 @@ type PlaceholderManager struct {
 }
 
 var placeholderMgr *PlaceholderManager
+var placeholderManagerLock sync.Mutex

Review comment:
       You are exactly correct. I have fixed the `TestFailApplication` following the example of `TestTryReserve`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org