You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Gorkem Ercan <go...@gmail.com> on 2013/11/05 22:19:22 UTC
Android target level for CLI
Hello,
Does anyone recall the reason for CLI to having "android-17" as a hard
target dependency.
--
Gorkem
Re: Android target level for CLI
Posted by Joe Bowser <bo...@gmail.com>.
I don't use the CLI, but I think that this is clearly a terrible idea,
especially since it may cause a broken "Quirks Mode" version of
Chrome WebView on Android 4.4. :(
On Tue, Nov 5, 2013 at 1:19 PM, Gorkem Ercan <go...@gmail.com> wrote:
> Hello,
> Does anyone recall the reason for CLI to having "android-17" as a hard
> target dependency.
> --
> Gorkem
Re: Android target level for CLI
Posted by Carlos Santana <cs...@gmail.com>.
Created issues to sync cheq requirements for CLI
https://issues.apache.org/jira/browse/CB-5298
https://issues.apache.org/jira/browse/CB-5297
On Tue, Nov 5, 2013 at 5:36 PM, Carlos Santana <cs...@gmail.com> wrote:
> Sorry wrong link for iOS Check Reqs
>
> https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
>
> Should I open jira issues for these 2?
>
>
>
> On Tue, Nov 5, 2013 at 5:31 PM, Carlos Santana <cs...@gmail.com>wrote:
>
>> Similar problem with iOS cheq_reqs
>>
>> CLI Checks for XCode 4.5 as min [1]
>> Platform Checks for XCode 4.6 as min [2]
>>
>> Which with XCode 5 out, I think Xcode 5.0.1 should be the minimum :-)
>>
>> [1]:
>> https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
>> [2]:
>> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>>
>>
>>
>> On Tue, Nov 5, 2013 at 4:59 PM, Carlos Santana <cs...@gmail.com>wrote:
>>
>>> Based on CLI Design [1]
>>> The CLI should not hold the code to check requirements (i.e.
>>> src/metadata/android_parser.js)
>>>
>>> The CLI instead should delegate to platform by calling
>>> (platform/android/cordova/check_reqs)
>>>
>>>
>>> Today there is duplicate of code not in sync for Android and iOS (other
>>> platforms delegate to cheq_reqs):
>>> CLI src/metadata/[platform]/check_requirements [2]
>>> Platform cordova/check_reqs [3]
>>>
>>>
>>>
>>> [1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
>>> [2]:
>>> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>>> [3]:
>>> https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js
>>>
>>>
>>> On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <br...@chromium.org>wrote:
>>>
>>>> I don't know how this value got updated in the past, it should
>>>> presumably
>>>> be set to target the latest version of Android.
>>>>
>>>> +1 for bumping it to 19.
>>>>
>>>> Braden
>>>>
>>>>
>>>> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <go...@gmail.com>
>>>> wrote:
>>>>
>>>> > Hello,
>>>> > Does anyone recall the reason for CLI to having "android-17" as a hard
>>>> > target dependency.
>>>> > --
>>>> > Gorkem
>>>> >
>>>>
>>>
>>>
>>>
>>> --
>>> Carlos Santana
>>> <cs...@gmail.com>
>>>
>>
>>
>>
>> --
>> Carlos Santana
>> <cs...@gmail.com>
>>
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
--
Carlos Santana
<cs...@gmail.com>
Re: Android target level for CLI
Posted by Carlos Santana <cs...@gmail.com>.
Sorry wrong link for iOS Check Reqs
https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
Should I open jira issues for these 2?
On Tue, Nov 5, 2013 at 5:31 PM, Carlos Santana <cs...@gmail.com> wrote:
> Similar problem with iOS cheq_reqs
>
> CLI Checks for XCode 4.5 as min [1]
> Platform Checks for XCode 4.6 as min [2]
>
> Which with XCode 5 out, I think Xcode 5.0.1 should be the minimum :-)
>
> [1]:
> https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
> [2]:
> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>
>
>
> On Tue, Nov 5, 2013 at 4:59 PM, Carlos Santana <cs...@gmail.com>wrote:
>
>> Based on CLI Design [1]
>> The CLI should not hold the code to check requirements (i.e.
>> src/metadata/android_parser.js)
>>
>> The CLI instead should delegate to platform by calling
>> (platform/android/cordova/check_reqs)
>>
>>
>> Today there is duplicate of code not in sync for Android and iOS (other
>> platforms delegate to cheq_reqs):
>> CLI src/metadata/[platform]/check_requirements [2]
>> Platform cordova/check_reqs [3]
>>
>>
>>
>> [1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
>> [2]:
>> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>> [3]:
>> https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js
>>
>>
>> On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <br...@chromium.org>wrote:
>>
>>> I don't know how this value got updated in the past, it should presumably
>>> be set to target the latest version of Android.
>>>
>>> +1 for bumping it to 19.
>>>
>>> Braden
>>>
>>>
>>> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <go...@gmail.com>
>>> wrote:
>>>
>>> > Hello,
>>> > Does anyone recall the reason for CLI to having "android-17" as a hard
>>> > target dependency.
>>> > --
>>> > Gorkem
>>> >
>>>
>>
>>
>>
>> --
>> Carlos Santana
>> <cs...@gmail.com>
>>
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
--
Carlos Santana
<cs...@gmail.com>
Re: Android target level for CLI
Posted by Shazron <sh...@gmail.com>.
5.0.1 should be the min if we want to go arm64:
https://issues.apache.org/jira/browse/CB-4863
On Tue, Nov 5, 2013 at 2:31 PM, Carlos Santana <cs...@gmail.com> wrote:
> Similar problem with iOS cheq_reqs
>
> CLI Checks for XCode 4.5 as min [1]
> Platform Checks for XCode 4.6 as min [2]
>
> Which with XCode 5 out, I think Xcode 5.0.1 should be the minimum :-)
>
> [1]:
>
> https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
> [2]:
>
> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
>
>
>
> On Tue, Nov 5, 2013 at 4:59 PM, Carlos Santana <cs...@gmail.com>
> wrote:
>
> > Based on CLI Design [1]
> > The CLI should not hold the code to check requirements (i.e.
> > src/metadata/android_parser.js)
> >
> > The CLI instead should delegate to platform by calling
> > (platform/android/cordova/check_reqs)
> >
> >
> > Today there is duplicate of code not in sync for Android and iOS (other
> > platforms delegate to cheq_reqs):
> > CLI src/metadata/[platform]/check_requirements [2]
> > Platform cordova/check_reqs [3]
> >
> >
> >
> > [1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
> > [2]:
> >
> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
> > [3]:
> >
> https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js
> >
> >
> > On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <braden@chromium.org
> >wrote:
> >
> >> I don't know how this value got updated in the past, it should
> presumably
> >> be set to target the latest version of Android.
> >>
> >> +1 for bumping it to 19.
> >>
> >> Braden
> >>
> >>
> >> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <go...@gmail.com>
> >> wrote:
> >>
> >> > Hello,
> >> > Does anyone recall the reason for CLI to having "android-17" as a hard
> >> > target dependency.
> >> > --
> >> > Gorkem
> >> >
> >>
> >
> >
> >
> > --
> > Carlos Santana
> > <cs...@gmail.com>
> >
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
Re: Android target level for CLI
Posted by Carlos Santana <cs...@gmail.com>.
Similar problem with iOS cheq_reqs
CLI Checks for XCode 4.5 as min [1]
Platform Checks for XCode 4.6 as min [2]
Which with XCode 5 out, I think Xcode 5.0.1 should be the minimum :-)
[1]:
https://github.com/apache/cordova-cli/blob/master/src/metadata/ios_parser.js#L32
[2]:
https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
On Tue, Nov 5, 2013 at 4:59 PM, Carlos Santana <cs...@gmail.com> wrote:
> Based on CLI Design [1]
> The CLI should not hold the code to check requirements (i.e.
> src/metadata/android_parser.js)
>
> The CLI instead should delegate to platform by calling
> (platform/android/cordova/check_reqs)
>
>
> Today there is duplicate of code not in sync for Android and iOS (other
> platforms delegate to cheq_reqs):
> CLI src/metadata/[platform]/check_requirements [2]
> Platform cordova/check_reqs [3]
>
>
>
> [1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
> [2]:
> https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
> [3]:
> https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js
>
>
> On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <br...@chromium.org>wrote:
>
>> I don't know how this value got updated in the past, it should presumably
>> be set to target the latest version of Android.
>>
>> +1 for bumping it to 19.
>>
>> Braden
>>
>>
>> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <go...@gmail.com>
>> wrote:
>>
>> > Hello,
>> > Does anyone recall the reason for CLI to having "android-17" as a hard
>> > target dependency.
>> > --
>> > Gorkem
>> >
>>
>
>
>
> --
> Carlos Santana
> <cs...@gmail.com>
>
--
Carlos Santana
<cs...@gmail.com>
Re: Android target level for CLI
Posted by Carlos Santana <cs...@gmail.com>.
Based on CLI Design [1]
The CLI should not hold the code to check requirements (i.e.
src/metadata/android_parser.js)
The CLI instead should delegate to platform by calling
(platform/android/cordova/check_reqs)
Today there is duplicate of code not in sync for Android and iOS (other
platforms delegate to cheq_reqs):
CLI src/metadata/[platform]/check_requirements [2]
Platform cordova/check_reqs [3]
[1]: http://wiki.apache.org/cordova/CommandLineToolingDesign
[2]:
https://github.com/apache/cordova-cli/blob/master/src/metadata/android_parser.js#L46
[3]:
https://github.com/apache/cordova-android/blob/master/bin/lib/check_reqs.js
On Tue, Nov 5, 2013 at 4:34 PM, Braden Shepherdson <br...@chromium.org>wrote:
> I don't know how this value got updated in the past, it should presumably
> be set to target the latest version of Android.
>
> +1 for bumping it to 19.
>
> Braden
>
>
> On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <go...@gmail.com>
> wrote:
>
> > Hello,
> > Does anyone recall the reason for CLI to having "android-17" as a hard
> > target dependency.
> > --
> > Gorkem
> >
>
--
Carlos Santana
<cs...@gmail.com>
Re: Android target level for CLI
Posted by Braden Shepherdson <br...@chromium.org>.
I don't know how this value got updated in the past, it should presumably
be set to target the latest version of Android.
+1 for bumping it to 19.
Braden
On Tue, Nov 5, 2013 at 4:19 PM, Gorkem Ercan <go...@gmail.com> wrote:
> Hello,
> Does anyone recall the reason for CLI to having "android-17" as a hard
> target dependency.
> --
> Gorkem
>