You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/01 16:24:09 UTC
[GitHub] [activemq-artemis] franz1981 opened a new pull request #3055:
ARTEMIS-2683 Paging should correctly handle message usage counter
franz1981 opened a new pull request #3055: ARTEMIS-2683 Paging should correctly handle message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 commented on issue #3055: ARTEMIS-1975
Fix AMQP paged large message usage counter
Posted by GitBox <gi...@apache.org>.
franz1981 commented on issue #3055: ARTEMIS-1975 Fix AMQP paged large message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055#issuecomment-607367530
I've noticed a thing while working on this PR on `PagedMessageImpl::decode`:
```java
if (isLargeMessage) {
int largeMessageHeaderSize = buffer.readInt();
if (storageManager == null) {
largeMessageLazyData = new byte[largeMessageHeaderSize];
buffer.readBytes(largeMessageLazyData);
} else {
```
the case where `storageManager == null` and is a core message; why `usageUp` isn't called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3055:
ARTEMIS-1975 Fix AMQP paged large message usage counter
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #3055: ARTEMIS-1975 Fix AMQP paged large message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055#issuecomment-607367530
@clebertsuconic
I've noticed a thing while working on this PR on `PagedMessageImpl::decode`:
```java
if (isLargeMessage) {
int largeMessageHeaderSize = buffer.readInt();
if (storageManager == null) {
largeMessageLazyData = new byte[largeMessageHeaderSize];
buffer.readBytes(largeMessageLazyData);
} else {
```
the case where `storageManager == null` and is a core message; why `usageUp` isn't called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit closed pull request #3055: ARTEMIS-1975
Fix AMQP paged large message usage counter
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3055: ARTEMIS-1975 Fix AMQP paged large message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] clebertsuconic commented on issue #3055:
ARTEMIS-1975 Fix AMQP paged large message usage counter
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on issue #3055: ARTEMIS-1975 Fix AMQP paged large message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055#issuecomment-607467723
I think that's for replication, where the storagemanager is not available right away? I don't remember.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] franz1981 edited a comment on issue #3055:
ARTEMIS-1975 Fix AMQP paged large message usage counter
Posted by GitBox <gi...@apache.org>.
franz1981 edited a comment on issue #3055: ARTEMIS-1975 Fix AMQP paged large message usage counter
URL: https://github.com/apache/activemq-artemis/pull/3055#issuecomment-607367530
@clebertsuconic
I've noticed a thing while working on this PR on `PagedMessageImpl::decode`:
```java
if (isLargeMessage) {
int largeMessageHeaderSize = buffer.readInt();
if (storageManager == null) {
largeMessageLazyData = new byte[largeMessageHeaderSize];
buffer.readBytes(largeMessageLazyData);
} else {
```
In the case where `storageManager == null` and is a core message, why `usageUp` isn't called?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services