[GitHub] [spark] Peng-Lei commented on a change in pull request #34780: [SPARK-37517][SQL] Keep consistent order of columns with user specify for v1 table

[GitBox <gi...@apache.org>]

Peng-Lei commented on a change in pull request #34780:
URL: https://github.com/apache/spark/pull/34780#discussion_r761016249



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ShowCreateTableSuite.scala
##########
@@ -226,6 +226,27 @@ abstract class ShowCreateTableSuite extends QueryTest with SQLTestUtils {
     }
   }
 
+  test("SPARK-37517: Keep consistent columns order with user specified") {
+    val t = "SPARK_37517"
+    withTable(t) {
+      sql(
+        s"""
+           |CREATE TABLE $t (
+           |  a bigint NOT NULL,

Review comment:
       I'm a little confused that the table will be created success although column `a` is nullable. It seems to me that partition columns should not be nullable. @cloud-fan  




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org