You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ben Hyde <bh...@gensym.com> on 1997/11/12 22:30:17 UTC
SunOS build
With Martin's additions to the SUNOS_LIB_PROTOTYPES section
in conf.h. I can now tame the SunOS build (at least for
my version of SunOS). Diff shown below
Meanwhile the problem with long filenames reported in
general/1404 apparently has two manifestations. On SunOS
is causes these warnings.
ar: filename mod_log_config.o truncated to mod_log_config.
ar: filename mod_negotiation.o truncated to mod_negotiation
But it doesn't prevent the link from succeeding.
- ben
---
Always enable SUNOS_LIB_PROTOTYPES since it's now needed.
Add a few const declarations there in to eliminate warnings
that it's arrival would otherwise trigger.
> cvs diff -c conf.h
Index: conf.h
===================================================================
RCS file: /cvs/apachen/src/main/conf.h,v
retrieving revision 1.157
diff -c -r1.157 conf.h
*** conf.h 1997/11/11 23:04:15 1.157
--- conf.h 1997/11/12 21:20:21
***************
*** 117,122 ****
--- 117,123 ----
#define USE_FLOCK_SERIALIZED_ACCEPT
#define NEED_DIFFTIME
#define HAVE_SYSLOG
+ #define SUNOS_LIB_PROTOTYPES
#elif defined(SOLARIS2)
#undef HAVE_GMTOFF
***************
*** 923,930 ****
int getopt(int, char **, char *);
! int strcasecmp(char *, char *);
! int strncasecmp(char *, char *, int);
int toupper(int);
int tolower(int);
--- 924,931 ----
int getopt(int, char **, char *);
! int strcasecmp(const char *, const char *);
! int strncasecmp(const char *, const char *, int);
int toupper(int);
int tolower(int);
***************
*** 945,951 ****
void perror(char *);
time_t time(time_t *);
! int strftime(char *, int, char *, struct tm *);
int initgroups(char *, int);
int wait3(int *, int, void *); /* Close enough for us... */
--- 946,952 ----
void perror(char *);
time_t time(time_t *);
! int strftime(char *, int, const char *, struct tm *);
int initgroups(char *, int);
int wait3(int *, int, void *); /* Close enough for us... */
***************
*** 969,975 ****
void syslog(int, char *,...);
char *mktemp(char *);
! long vfprintf(FILE *, char *, va_list);
#endif /* SUNOS_LIB_PROTOTYPES */
--- 970,976 ----
void syslog(int, char *,...);
char *mktemp(char *);
! long vfprintf(FILE *, const char *, va_list);
#endif /* SUNOS_LIB_PROTOTYPES */
>
Re: SunOS build
Posted by Martin Kraemer <Ma...@mch.sni.de>.
On Wed, Nov 12, 1997 at 04:30:17PM -0400, Ben Hyde wrote:
> ... Diff shown below
Excellent! Thanks for this patch - I think we can commit it as the
default for all SUNOS4 versions (until further notice...?!?)
+1 from me - though I cannot test it myself ("visual code review" =-).
Martin
--
| S I E M E N S | <Ma...@mch.sni.de> | Siemens Nixdorf
| ------------- | Voice: +49-89-636-46021 | Informationssysteme AG
| N I X D O R F | FAX: +49-89-636-44994 | 81730 Munich, Germany
~~~~~~~~~~~~~~~~My opinions only, of course; pgp key available on request
Re: SunOS build
Posted by Dirk-Willem van Gulik <di...@elect6.jrc.it>.
On Wed, 12 Nov 1997, Ben Hyde wrote:
> ar: filename mod_log_config.o truncated to mod_log_config.
> ar: filename mod_negotiation.o truncated to mod_negotiation
>
> But it doesn't prevent the link from succeeding.
Same here. Seems the perfect solution.
>
> Always enable SUNOS_LIB_PROTOTYPES since it's now needed.
> Add a few const declarations there in to eliminate warnings
> that it's arrival would otherwise trigger.
+1 for me.
Re: SunOS build
Posted by Marc Slemko <ma...@worldgate.com>.
On Wed, 12 Nov 1997, Ben Hyde wrote:
> With Martin's additions to the SUNOS_LIB_PROTOTYPES section
> in conf.h. I can now tame the SunOS build (at least for
> my version of SunOS). Diff shown below
I'm not sure I like enabling all those declarations. I am worried it is
likely to cause more problems than it will fix.
>
> Meanwhile the problem with long filenames reported in
> general/1404 apparently has two manifestations. On SunOS
> is causes these warnings.
>
> ar: filename mod_log_config.o truncated to mod_log_config.
> ar: filename mod_negotiation.o truncated to mod_negotiation
What ar are you using?
>
> But it doesn't prevent the link from succeeding.
>
> - ben
>
> ---
>
> Always enable SUNOS_LIB_PROTOTYPES since it's now needed.
> Add a few const declarations there in to eliminate warnings
> that it's arrival would otherwise trigger.
>
>
> > cvs diff -c conf.h
> Index: conf.h
> ===================================================================
> RCS file: /cvs/apachen/src/main/conf.h,v
> retrieving revision 1.157
> diff -c -r1.157 conf.h
> *** conf.h 1997/11/11 23:04:15 1.157
> --- conf.h 1997/11/12 21:20:21
> ***************
> *** 117,122 ****
> --- 117,123 ----
> #define USE_FLOCK_SERIALIZED_ACCEPT
> #define NEED_DIFFTIME
> #define HAVE_SYSLOG
> + #define SUNOS_LIB_PROTOTYPES
>
> #elif defined(SOLARIS2)
> #undef HAVE_GMTOFF
> ***************
> *** 923,930 ****
>
> int getopt(int, char **, char *);
>
> ! int strcasecmp(char *, char *);
> ! int strncasecmp(char *, char *, int);
> int toupper(int);
> int tolower(int);
>
> --- 924,931 ----
>
> int getopt(int, char **, char *);
>
> ! int strcasecmp(const char *, const char *);
> ! int strncasecmp(const char *, const char *, int);
> int toupper(int);
> int tolower(int);
>
> ***************
> *** 945,951 ****
> void perror(char *);
>
> time_t time(time_t *);
> ! int strftime(char *, int, char *, struct tm *);
>
> int initgroups(char *, int);
> int wait3(int *, int, void *); /* Close enough for us... */
> --- 946,952 ----
> void perror(char *);
>
> time_t time(time_t *);
> ! int strftime(char *, int, const char *, struct tm *);
>
> int initgroups(char *, int);
> int wait3(int *, int, void *); /* Close enough for us... */
> ***************
> *** 969,975 ****
> void syslog(int, char *,...);
> char *mktemp(char *);
>
> ! long vfprintf(FILE *, char *, va_list);
>
> #endif /* SUNOS_LIB_PROTOTYPES */
>
> --- 970,976 ----
> void syslog(int, char *,...);
> char *mktemp(char *);
>
> ! long vfprintf(FILE *, const char *, va_list);
>
> #endif /* SUNOS_LIB_PROTOTYPES */
>
> >
>
Re: SunOS build
Posted by Dean Gaudet <dg...@arctic.org>.
This looks right to me ... +1, but I have no way of testing it. I figured
SUNOS_LIB_PROTOTYPES was always defined... I guess the only time it
shouldn't be defined is if you have a gnu libc system. Perhaps it should
be a true/false define so glibc folks can disable it.
Dean
On Wed, 12 Nov 1997, Ben Hyde wrote:
> With Martin's additions to the SUNOS_LIB_PROTOTYPES section
> in conf.h. I can now tame the SunOS build (at least for
> my version of SunOS). Diff shown below
>
> Meanwhile the problem with long filenames reported in
> general/1404 apparently has two manifestations. On SunOS
> is causes these warnings.
>
> ar: filename mod_log_config.o truncated to mod_log_config.
> ar: filename mod_negotiation.o truncated to mod_negotiation
>
> But it doesn't prevent the link from succeeding.
>
> - ben
>
> ---
>
> Always enable SUNOS_LIB_PROTOTYPES since it's now needed.
> Add a few const declarations there in to eliminate warnings
> that it's arrival would otherwise trigger.
>
>
> > cvs diff -c conf.h
> Index: conf.h
> ===================================================================
> RCS file: /cvs/apachen/src/main/conf.h,v
> retrieving revision 1.157
> diff -c -r1.157 conf.h
> *** conf.h 1997/11/11 23:04:15 1.157
> --- conf.h 1997/11/12 21:20:21
> ***************
> *** 117,122 ****
> --- 117,123 ----
> #define USE_FLOCK_SERIALIZED_ACCEPT
> #define NEED_DIFFTIME
> #define HAVE_SYSLOG
> + #define SUNOS_LIB_PROTOTYPES
>
> #elif defined(SOLARIS2)
> #undef HAVE_GMTOFF
> ***************
> *** 923,930 ****
>
> int getopt(int, char **, char *);
>
> ! int strcasecmp(char *, char *);
> ! int strncasecmp(char *, char *, int);
> int toupper(int);
> int tolower(int);
>
> --- 924,931 ----
>
> int getopt(int, char **, char *);
>
> ! int strcasecmp(const char *, const char *);
> ! int strncasecmp(const char *, const char *, int);
> int toupper(int);
> int tolower(int);
>
> ***************
> *** 945,951 ****
> void perror(char *);
>
> time_t time(time_t *);
> ! int strftime(char *, int, char *, struct tm *);
>
> int initgroups(char *, int);
> int wait3(int *, int, void *); /* Close enough for us... */
> --- 946,952 ----
> void perror(char *);
>
> time_t time(time_t *);
> ! int strftime(char *, int, const char *, struct tm *);
>
> int initgroups(char *, int);
> int wait3(int *, int, void *); /* Close enough for us... */
> ***************
> *** 969,975 ****
> void syslog(int, char *,...);
> char *mktemp(char *);
>
> ! long vfprintf(FILE *, char *, va_list);
>
> #endif /* SUNOS_LIB_PROTOTYPES */
>
> --- 970,976 ----
> void syslog(int, char *,...);
> char *mktemp(char *);
>
> ! long vfprintf(FILE *, const char *, va_list);
>
> #endif /* SUNOS_LIB_PROTOTYPES */
>
> >
>