You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2017/01/27 00:32:09 UTC
Review Request 56006: Added CHECK logging to the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56006/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
Added CHECK logging to the allocator.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a
Diff: https://reviews.apache.org/r/56006/diff/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 56006: Added CHECK logging to the allocator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56006/#review163223
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 432)
<https://reviews.apache.org/r/56006/#comment234686>
How about make the log messsage more clear such as
```
CHECK(framework.roles == newRoles)
<< stringify(framework.roles) << " does not match " << stringify(newRoles);
```
- Guangya Liu
On \u4e00\u6708 27, 2017, 12:32 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56006/
> -----------------------------------------------------------
>
> (Updated \u4e00\u6708 27, 2017, 12:32 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CHECK logging to the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a
>
> Diff: https://reviews.apache.org/r/56006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 56006: Added CHECK logging to the allocator.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56006/#review163878
-----------------------------------------------------------
Ship it!
src/master/allocator/mesos/hierarchical.cpp (line 431)
<https://reviews.apache.org/r/56006/#comment235360>
I think I asked why we couldn't use `CHECK_EQ` here in a previous review.
- Michael Park
On Jan. 26, 2017, 4:32 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56006/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 4:32 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added CHECK logging to the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp c2211be7458755aeb91ef078e4bfe92ac474044a
>
> Diff: https://reviews.apache.org/r/56006/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>