You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/11/03 16:10:21 UTC

[GitHub] [flink] matriv commented on pull request #17658: [FLINK-24684][table-planner] Add to string cast rules using the new CastRule stack

matriv commented on pull request #17658:
URL: https://github.com/apache/flink/pull/17658#issuecomment-959587919


   > @matriv regarding testing the rules in `CastFunctionsITCase`, I effectively found out that the row, array and map rules doesn't work, because some validation steps before (`SqlValidatorImpl` and `LogicalTypeCasts`) thinks the cast combination is invalid. Because the goal of this PR is to simply port the logic from `ScalarOperatorGens` to the new rules, perhaps should we tackle the issue of "exposing" the rules in the context of https://issues.apache.org/jira/browse/FLINK-21456?
   
   
   Yes of course, my mistake, thought those casts work end to end now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org