You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/20 18:46:59 UTC

[GitHub] [flink] tweise commented on a diff in pull request #20844: [FLINK-29099][connectors/kinesis] Update global watermark for idle subtask

tweise commented on code in PR #20844:
URL: https://github.com/apache/flink/pull/20844#discussion_r1027335236


##########
flink-connectors/flink-connector-kinesis/src/main/java/org/apache/flink/streaming/connectors/kinesis/util/JobManagerWatermarkTracker.java:
##########
@@ -92,6 +104,7 @@ public long getUpdateTimeoutCount() {
     protected static class WatermarkUpdate implements Serializable {
         protected long watermark = Long.MIN_VALUE;
         protected String id;
+        protected boolean updateLocalWatermark = true;

Review Comment:
   @sethsaperstein-lyft instead of adding this field and `getWatermark`, wouldn't it be simple to use `Long.MIN_VALUE` as a special value with `updateWatermark`? We already use `Long.MIN_VALUE` as "no watermark" in the fetcher and can designate is as idle in the accumulator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org