You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Jakob Homan (JIRA)" <ji...@apache.org> on 2012/06/06 12:39:24 UTC
[jira] [Created] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Jakob Homan created HIVE-3092:
---------------------------------
Summary: Hive tests should load Hive classes from build directory, not Ivy cache
Key: HIVE-3092
URL: https://issues.apache.org/jira/browse/HIVE-3092
Project: Hive
Issue Type: Bug
Components: Testing Infrastructure, Tests
Reporter: Jakob Homan
As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296073#comment-13296073 ]
Kanna Karanam commented on HIVE-3092:
-------------------------------------
I am not sure with the implications of excluding lib*.jar from dist folder but this workaround is working on windows.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295164#comment-13295164 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
Also added a comment.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296058#comment-13296058 ]
Carl Steinbach commented on HIVE-3092:
--------------------------------------
libfb303.jar and libthrift.jar are symlinks which were added in HIVE-1962. Maybe we can remove them?
@Kevin: Can you check with Ning and see if Facebook still has an internal dependency on these old JAR names?
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296057#comment-13296057 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
Have you tried running ant clean?
If that doesn't work have you tried ant very-clean?
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295223#comment-13295223 ]
Carl Steinbach commented on HIVE-3092:
--------------------------------------
+1
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295623#comment-13295623 ]
Hudson commented on HIVE-3092:
------------------------------
Integrated in Hive-trunk-h0.21 #1488 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1488/])
HIVE-3092 Hive tests should load Hive classes from build directory, not Ivy cache
(Kevin Wilfong via namit) (Revision 1350467)
Result = FAILURE
namit : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1350467
Files :
* /hive/trunk/build-common.xml
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399766#comment-13399766 ]
Kanna Karanam commented on HIVE-3092:
-------------------------------------
Hi Kevin - Any update on this. Thanks
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396110#comment-13396110 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
I've attempted to contact Ning, still waiting on a reply.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294755#comment-13294755 ]
Namit Jain commented on HIVE-3092:
----------------------------------
This was a very serious bug introduced by HIVE-2646.
+1
If anyone has any issues, please comment - I will start to run tests.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294880#comment-13294880 ]
Carl Steinbach commented on HIVE-3092:
--------------------------------------
This patch will fix the problem in cases where new classes are added, or where the definition of a class has changed. However, it won't fix the situation where a class is removed but continues to show up on the classpath because Ivy is pulling an old copy out of the local cache.
I think HIVE-3116 is a better way to fix the problem since it addresses all three of the cases I described above.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong reassigned HIVE-3092:
-----------------------------------
Assignee: Kevin Wilfong
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3092:
--------------------------------
Attachment: HIVE-3092.1.patch.txt
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294888#comment-13294888 ]
Carl Steinbach commented on HIVE-3092:
--------------------------------------
I also don't think this fix will stay in place for very long unless someone adds a comment explaining why the dist/lib directory has to go first on the classpath.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296113#comment-13296113 ]
Kanna Karanam commented on HIVE-3092:
-------------------------------------
Thanks Carl - Sorry I think my original message was a bit ambiguous, I did the following under “test-classpath” in build-common.xml to unblock myself for now.
Original:
<fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar "/>
Modife:
<fileset dir="${build.dir.hive}/dist/lib" includes="*.jar" erroronmissingdir="false" excludes="**/hive_contrib*.jar,**/hive-contrib*.jar,**/lib*.jar"/>
I will try your suggestion tomorrow.
Thanks
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400191#comment-13400191 ]
Kanna Karanam commented on HIVE-3092:
-------------------------------------
Thanks Kevin. All Unit Tests passed without lib*.jar symlinks. so I addressed it as part of overall windows build patch(HIVE-3126).
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296107#comment-13296107 ]
Carl Steinbach commented on HIVE-3092:
--------------------------------------
@Kanna: You can't exclude libfb303-0.7.0.jar or libthrift-0.7.0.jar from the dist/lib directory since these are required by different components of Hive. However, it's perfectly acceptable to remove the symlinks libfb303.jar and libthrift.jar. In fact, we should just remove the code in build.xml which creates these symlinks. The relevant code that needs to be removed starts on line 536 of build.xml.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396108#comment-13396108 ]
Kanna Karanam commented on HIVE-3092:
-------------------------------------
@Carl - It is working after removing the symlinks from build.xml. Once Kevin confirm that they are no more required then we can remove them from build.xml
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13399789#comment-13399789 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
No, he never got back to me.
I spoke with Namit Jain who worked with Ning, he didn't think it was needed anymore.
If you can remove it and the tests still pass, it's probably ok, otherwise, we'll find a deficiency in our tests that should be fixed.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Namit Jain updated HIVE-3092:
-----------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed. Thanks Kevin
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3092:
--------------------------------
Attachment: HIVE-3092.2.patch.txt
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13295163#comment-13295163 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
Carl did have a good point, this patch did not fix the case where a class is removed.
In my newly uploaded patch, when the test class path is constructed it adds the jars from build/dist/lib before the Ivy jars, and excludes all hive jars from Ivy.
So now, for the 3 cases Carl mentioned, this patch fixes them for ant test. It also means that we can run the tests after running the much faster ant clean rather than ant very-clean. Finally, it means that different checkouts won't read their Hive jars from the common Ivy repo resulting in potentially picking up the changes in another checkout. Given that, I would argue that for the case of running the command ant test, this patch is better than the fix proposed in HIVE-3116, although that has value for other cases.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294894#comment-13294894 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
Carl, do you happen to know why these Hive artifacts are going into Ivy's cache in the first place? If we could remove them from there, or at least find some other way to ignore them, that would solve the problems as well.
Having multiple checkouts of Hive store these jars in a common location and then use them makes it very difficult to work in multiple checkouts at the same time. It also complicates testing multiple checkouts at the same time.
Given that there isn't a patch for HIVE-3116 yet, I'd like to get this in, to help speed up development. Having to run ant very-clean package which takes ~20 mins. every time you make a change is a real time sink.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kevin Wilfong updated HIVE-3092:
--------------------------------
Status: Patch Available (was: Open)
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kevin Wilfong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294715#comment-13294715 ]
Kevin Wilfong commented on HIVE-3092:
-------------------------------------
The attached patch attempts to solve the problem by adding the jars from build/dist/lib into the test classpath before the Ivy jars.
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3092) Hive tests should load Hive classes
from build directory, not Ivy cache
Posted by "Kanna Karanam (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13296054#comment-13296054 ]
Kanna Karanam commented on HIVE-3092:
-------------------------------------
I am getting the following error on windows when I run the unit tests with these changes. Do you have any suggestions to make it work on windows?
compile-test:
[echo] Project: ql
[javac] Compiling 57 source files to D:\OSS\hive\build\ql\test\classes
[javac] error: error reading D:\OSS\hive\build\dist\lib\libfb303.jar; error in opening zip file
[javac] error: error reading D:\OSS\hive\build\dist\lib\libthrift.jar; error in opening zip file
[javac] 2 errors
> Hive tests should load Hive classes from build directory, not Ivy cache
> -----------------------------------------------------------------------
>
> Key: HIVE-3092
> URL: https://issues.apache.org/jira/browse/HIVE-3092
> Project: Hive
> Issue Type: Bug
> Components: Testing Infrastructure, Tests
> Reporter: Jakob Homan
> Assignee: Kevin Wilfong
> Attachments: HIVE-3092.1.patch.txt, HIVE-3092.2.patch.txt
>
>
> As discussed in HIVE-895, currently the tests pull in jars for other components rather from Ivy rather than using the built classes and jars in the build directory (bit.ly/LzndQU). This means that absent a very-clean, one is testing against a previous version of the code and cross-component tests are invalid.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira