[jira] Commented: (PIVOT-211) confirm catch blocks to either re-throw or have a good reason for ignoring exception

["Greg Brown (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIVOT-211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740054#action_12740054 ] 

Greg Brown commented on PIVOT-211:
----------------------------------

Overall, this looks good. Most of my comments are style-related:

- "no-op" should be "No-op" - we generally start comments with a capital letter

- I think it is OK to omit the "// should never happen" comments

- Should probably write to System.err here, and use a colon:

  System.out.println("Unable to open URL in default browser. " + exception.getMessage());

  ->

  System.err.println("Unable to open URL in default browser: " + exception.getMessage());

- In ApplicationContext#queueCallback(), we should probably wrap and throw, as you have done.




> confirm catch blocks to either re-throw or have a good reason for ignoring exception
> ------------------------------------------------------------------------------------
>
>                 Key: PIVOT-211
>                 URL: https://issues.apache.org/jira/browse/PIVOT-211
>             Project: Pivot
>          Issue Type: Improvement
>    Affects Versions: 1.3
>            Reporter: Noel Grandin
>            Assignee: Noel Grandin
>         Attachments: fix-catch-blocks.6aug.patch
>
>
> Go through the catch blocks and make sure that either
> (a) the exception is re-thrown
> (b) there is a comment explaining why it can be ignored

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.