You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2020/08/22 00:54:08 UTC

[GitHub] [guacamole-server] necouchman commented on pull request #228: GUACAMOLE-221: Implement guacd support for prompting

necouchman commented on pull request #228:
URL: https://github.com/apache/guacamole-server/pull/228#issuecomment-678570036


   @mike-jumper: Okay, I've cleaned up several things and reworked the code onto your changes from #297. I don't think this is quite ready for merge, yet, but probably ready for another round of review.
   
   The one thing I'm still not real happy with right now is the SSH code handling of credential retrieval - the prompting through the `required` instruction is adding complexity that makes it a little messy right now.  It seems like there is probably a better way to streamline things such that the `guac_common_ssh_user` code handles everything and it isn't so strewn all over the place like it is right now.  I'm going to try poking at that a bit and see what shakes out...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org