You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ozone.apache.org by GitBox <gi...@apache.org> on 2021/02/06 09:27:27 UTC
[GitHub] [ozone-docker-runner] adoroszlai commented on a change in pull request #1: HDDS-4795. Separate source of Ozone container images to different repositories
adoroszlai commented on a change in pull request #1:
URL: https://github.com/apache/ozone-docker-runner/pull/1#discussion_r571382666
##########
File path: README.md
##########
@@ -15,15 +15,35 @@
limitations under the License.
-->
-# Apache Ozone runner base image
+# Apache Ozone **runner** base image
-This is the base image to run Apache Hadoop Ozone in docker containers. This is for test/develop and not for production.
+This is the base image to run Apache Hadoop Ozone in docker containers. This is only for test/develop and not for production.
-It doesn't include any Ozone specific jar files or release artifacts just any empty environment which includes all the specific tools to run Apache Hadoop Ozone inside containers.
+The container doesn't include any Ozone specific jar files or release artifacts just an empty environment which includes all the specific tools to run and test Apache Ozone inside containers.
-To build it, please use:
+The image is available as [apache/ozone-runner](https://hub.docker.com/r/apache/ozone-runner). Build is managed by Docker Hub.
+
+## Development
+
+To build the image, please use:
+
+```
+docker build -t apache/ozone-runner:dev .
+```
+
+To test it with Apache Ozone, do a custom build:
Review comment:
```suggestion
To test it, build [Apache Ozone](https://github.com/apache/ozone):
```
##########
File path: README.md
##########
@@ -15,15 +15,35 @@
limitations under the License.
-->
-# Apache Ozone runner base image
+# Apache Ozone **runner** base image
-This is the base image to run Apache Hadoop Ozone in docker containers. This is for test/develop and not for production.
+This is the base image to run Apache Hadoop Ozone in docker containers. This is only for test/develop and not for production.
-It doesn't include any Ozone specific jar files or release artifacts just any empty environment which includes all the specific tools to run Apache Hadoop Ozone inside containers.
+The container doesn't include any Ozone specific jar files or release artifacts just an empty environment which includes all the specific tools to run and test Apache Ozone inside containers.
-To build it, please use:
+The image is available as [apache/ozone-runner](https://hub.docker.com/r/apache/ozone-runner). Build is managed by Docker Hub.
+
+## Development
+
+To build the image, please use:
+
+```
+docker build -t apache/ozone-runner:dev .
+```
+
+To test it with Apache Ozone, do a custom build:
```
-docker build -t apache/ozone-runner
+mvn clean install -DskipTests -Dskip.npx -DskipShade -o -Ddocker.ozone-runner.version=dev
Review comment:
I think "offline" mode is not required here, and I'd rather avoid install into local repo.
```suggestion
mvn clean verify -DskipTests -Dskip.npx -DskipShade -Ddocker.ozone-runner.version=dev
```
##########
File path: .github/workflows/build.yaml
##########
@@ -0,0 +1,26 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+name: build
+on:
+ - push
Review comment:
Should it also build on PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ozone.apache.org
For additional commands, e-mail: dev-help@ozone.apache.org