You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Chia-Ping Tsai (JIRA)" <ji...@apache.org> on 2018/03/18 05:27:00 UTC
[jira] [Comment Edited] (HBASE-20212) Make all Public classes have
InterfaceAudience category
[ https://issues.apache.org/jira/browse/HBASE-20212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403480#comment-16403480 ]
Chia-Ping Tsai edited comment on HBASE-20212 at 3/18/18 5:26 AM:
-----------------------------------------------------------------
{quote}yeah, can do few modules at a time to chunk up the work.
{quote}
Try to simplify our rules. The regular expression is shown below.
{code:java}
(?!.*(.generated.|.tmpl.|\$)).*{code}
The following classes will be EXCLUDED
1) nested class
The nested class should default have same InterfaceAudience as with root class unless it has another InterfaceAudience explicitly.
2) generated by protobuf
3) generated by jamon
4) generated by thrift (thank [~stack])
If we apply above regular expression, the count of invalid classes is about 200. It seems to me one patch can fix all.
Need suggestions (or +1)
was (Author: chia7712):
{quote}yeah, can do few modules at a time to chunk up the work.
{quote}
Try to simplify our rules. The regular expression is shown below.
{code:java}
(?!.*(.generated.|.tmpl.|\$)).*{code}
The following classes will be EXCLUDED
1) nested class
The nested class should default have same InterfaceAudience as with root class unless it has another InterfaceAudience explicitly.
2) generated by protobuf
3) generated by jamon
4) generated by thrift
If we apply above regular expression, the count of invalid classes is about 200. It seems to me one patch can fix all.
Need suggestions (or +1)
> Make all Public classes have InterfaceAudience category
> -------------------------------------------------------
>
> Key: HBASE-20212
> URL: https://issues.apache.org/jira/browse/HBASE-20212
> Project: HBase
> Issue Type: Task
> Reporter: Chia-Ping Tsai
> Assignee: Chia-Ping Tsai
> Priority: Critical
> Fix For: 2.0.0, 3.0.0, 2.1.0
>
>
> The tasks will be resolved are shown below.
> # add warbucks-maven-plugin to root pom
> # make sure all sub modules ref the warbucks-maven-plugin
> # remove old checker (TestInterfaceAudienceAnnotations)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)