You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/06/15 07:45:35 UTC
[GitHub] [lucene] kkewwei opened a new pull request #183: LUCENE-9998: delete useless param fis in StoredFieldsWriter.finish() and TermVectorsWriter.finish()
kkewwei opened a new pull request #183:
URL: https://github.com/apache/lucene/pull/183
# Description
the paramater `fis` in In StoredFieldsWriter.finish() and TermVectorsWriter.finish() is useless, and deleting it would help simplify the API.
# Solution
Deleting it from StoredFieldsWriter.finish() and TermVectorsWriter.finish(), including those subclasses
# Tests
Just run ./gradlew precommit ./gradlew test ./gradlew check
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] kkewwei commented on pull request #183: LUCENE-9998: delete useless param fis in StoredFieldsWriter.finish() and TermVectorsWriter.finish()
Posted by GitBox <gi...@apache.org>.
kkewwei commented on pull request #183:
URL: https://github.com/apache/lucene/pull/183#issuecomment-861494424
I have added the note, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #183: LUCENE-9998: delete useless param fis in StoredFieldsWriter.finish() and TermVectorsWriter.finish()
Posted by GitBox <gi...@apache.org>.
jpountz commented on pull request #183:
URL: https://github.com/apache/lucene/pull/183#issuecomment-861480777
Right above line 130 (`Improvements`) in `lucene/CHANGES.txt` on your working copy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #183: LUCENE-9998: delete useless param fis in StoredFieldsWriter.finish() and TermVectorsWriter.finish()
Posted by GitBox <gi...@apache.org>.
jpountz merged pull request #183:
URL: https://github.com/apache/lucene/pull/183
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] kkewwei commented on pull request #183: LUCENE-9998: delete useless param fis in StoredFieldsWriter.finish() and TermVectorsWriter.finish()
Posted by GitBox <gi...@apache.org>.
kkewwei commented on pull request #183:
URL: https://github.com/apache/lucene/pull/183#issuecomment-861367299
Of course, Can you tell me where I can add the node? I can't find the place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org