You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "honghua zhu (Created) (JIRA)" <ji...@apache.org> on 2012/02/29 17:11:57 UTC
[jira] [Created] (HBASE-5491) Delete the HBaseConfiguration.create
for coprocessor.Exec class
Delete the HBaseConfiguration.create for coprocessor.Exec class
---------------------------------------------------------------
Key: HBASE-5491
URL: https://issues.apache.org/jira/browse/HBASE-5491
Project: HBase
Issue Type: Improvement
Components: coprocessors
Affects Versions: 0.92.0
Environment: all
Reporter: honghua zhu
Fix For: 0.92.1
Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
Is so HBaseConfiguration.create for each request needs to call
When the server side deserialize the Exec Called once HBaseConfiguration.create in,
HBaseConfiguration.create is a time consuming operation.
"private Configuration conf = HBaseConfiguration.create()";
This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
other places with the Exec class, pass a Configuration come,
so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "honghua zhu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
honghua zhu updated HBASE-5491:
-------------------------------
Attachment: HBASE-5491-2.patch
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-5491) Delete the
HBaseConfiguration.create for coprocessor.Exec class
Posted by "Zhihong Yu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219338#comment-13219338 ]
Zhihong Yu edited comment on HBASE-5491 at 2/29/12 4:53 PM:
------------------------------------------------------------
The default Exec ctor is only used by TestCoprocessorEndpoint
I think we shouldn't introduce public method(s) just for unit tests.
Stack's last comment makes sense.
@Honghua:
Can you attach a new patch ?
was (Author: zhihyu@ebaysf.com):
The default Exec ctor is only used by TestCoprocessorEndpoint
I think we shouldn't introduce public method(s) just for unit tests.
Stack's last comment makes sense.
@Honghai:
Can you attach a new patch ?
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219885#comment-13219885 ]
Hudson commented on HBASE-5491:
-------------------------------
Integrated in HBase-0.94 #5 (See [https://builds.apache.org/job/HBase-0.94/5/])
HBASE-5491 Remove HBaseConfiguration.create() call from coprocessor.Exec class (Revision 1295431)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Exec.java
* /hbase/branches/0.94/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5491) Delete the HBaseConfiguration.create
for coprocessor.Exec class
Posted by "honghua zhu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
honghua zhu updated HBASE-5491:
-------------------------------
Attachment: HBASE-5491.patch
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Andrew Purtell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219470#comment-13219470 ]
Andrew Purtell commented on HBASE-5491:
---------------------------------------
+1
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222123#comment-13222123 ]
Hudson commented on HBASE-5491:
-------------------------------
Integrated in HBase-0.92-security #96 (See [https://builds.apache.org/job/HBase-0.92-security/96/])
HBASE-5491 Remove HBaseConfiguration.create() call from coprocessor.Exec class (Revision 1295430)
Result = FAILURE
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Exec.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Delete the
HBaseConfiguration.create for coprocessor.Exec class
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219316#comment-13219316 ]
stack commented on HBASE-5491:
------------------------------
Although, one question Honghua, why not remove the setConf and in the test do new Exec(HBaseConfiguration.create())?
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Delete the
HBaseConfiguration.create for coprocessor.Exec class
Posted by "honghua zhu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219334#comment-13219334 ]
honghua zhu commented on HBASE-5491:
------------------------------------
@stack
I just do not want to repair a lot of code. :)
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220258#comment-13220258 ]
Hudson commented on HBASE-5491:
-------------------------------
Integrated in HBase-TRUNK #2671 (See [https://builds.apache.org/job/HBase-TRUNK/2671/])
HBASE-5491 Remove HBaseConfiguration.create() call from coprocessor.Exec class (Revision 1295429)
Result = FAILURE
stack :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Exec.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219755#comment-13219755 ]
Zhihong Yu commented on HBASE-5491:
-----------------------------------
Patch v2 looks good.
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Delete the
HBaseConfiguration.create for coprocessor.Exec class
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219315#comment-13219315 ]
stack commented on HBASE-5491:
------------------------------
+1 on patch. Will add comment that setConf is for testing only on commit. Waiting on hadoopqa before committing.
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219937#comment-13219937 ]
Hudson commented on HBASE-5491:
-------------------------------
Integrated in HBase-0.92 #309 (See [https://builds.apache.org/job/HBase-0.92/309/])
HBASE-5491 Remove HBaseConfiguration.create() call from coprocessor.Exec class (Revision 1295430)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.92/CHANGES.txt
* /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/coprocessor/Exec.java
* /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorEndpoint.java
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "honghua zhu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219710#comment-13219710 ]
honghua zhu commented on HBASE-5491:
------------------------------------
@stack
Well, you are right. :)
I do not understand the original author why introduced the conf field to Exec class,
Exec extends org.apache.hadoop.hbase.ipc.Invocation
where has a conf field too.
I think that the new Exec(HBaseConfiguration.create()) is not necessary.
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219527#comment-13219527 ]
stack commented on HBASE-5491:
------------------------------
@Honghua My suggestion would make your patch smaller.
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Delete the
HBaseConfiguration.create for coprocessor.Exec class
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219338#comment-13219338 ]
Zhihong Yu commented on HBASE-5491:
-----------------------------------
The default Exec ctor is only used by TestCoprocessorEndpoint
I think we shouldn't introduce public method(s) just for unit tests.
Stack's last comment makes sense.
@Honghai:
Can you attach a new patch ?
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219740#comment-13219740 ]
Hadoop QA commented on HBASE-5491:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516630/HBASE-5491-2.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -131 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1064//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1064//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1064//console
This message is automatically generated.
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5491:
-------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.92, 0.94 and trunk. Thanks for the patch Honghua
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219794#comment-13219794 ]
stack commented on HBASE-5491:
------------------------------
+1
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491-2.patch, HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5491:
------------------------------
Summary: Remove HBaseConfiguration.create() call from coprocessor.Exec class (was: Delete the HBaseConfiguration.create for coprocessor.Exec class)
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5491) Delete the HBaseConfiguration.create
for coprocessor.Exec class
Posted by "honghua zhu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
honghua zhu updated HBASE-5491:
-------------------------------
Status: Patch Available (was: Open)
> Delete the HBaseConfiguration.create for coprocessor.Exec class
> ---------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5491) Remove HBaseConfiguration.create()
call from coprocessor.Exec class
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13219347#comment-13219347 ]
Hadoop QA commented on HBASE-5491:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516576/HBASE-5491.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -131 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.replication.TestReplicationPeer
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.io.hfile.TestLruBlockCache
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1062//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1062//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1062//console
This message is automatically generated.
> Remove HBaseConfiguration.create() call from coprocessor.Exec class
> -------------------------------------------------------------------
>
> Key: HBASE-5491
> URL: https://issues.apache.org/jira/browse/HBASE-5491
> Project: HBase
> Issue Type: Improvement
> Components: coprocessors
> Affects Versions: 0.92.0
> Environment: all
> Reporter: honghua zhu
> Fix For: 0.92.1
>
> Attachments: HBASE-5491.patch
>
>
> Exec class has a field: "private Configuration conf = HBaseConfiguration.create()"
> Client side generates an Exec instance of the class, each initiated Statistics request by ExecRPCInvoker
> Is so HBaseConfiguration.create for each request needs to call
> When the server side deserialize the Exec Called once HBaseConfiguration.create in,
> HBaseConfiguration.create is a time consuming operation.
> "private Configuration conf = HBaseConfiguration.create()";
> This code is only useful for testing code (org.apache.hadoop.hbase.coprocessor.TestCoprocessorEndpoint.testExecDeserialization),
> other places with the Exec class, pass a Configuration come,
> so no need to "conf" field a default value.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira