You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "hanshal101 (via GitHub)" <gi...@apache.org> on 2023/03/15 16:23:21 UTC
[GitHub] [incubator-eventmesh] hanshal101 opened a new pull request, #3456: Update 07-tracing.md
hanshal101 opened a new pull request, #3456:
URL: https://github.com/apache/incubator-eventmesh/pull/3456
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #<XXXX>.
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#issuecomment-1627600800
Allow me to be candid and honest with you. It is not appropriate nor advisable to directly use machine translation on Markdown text. This not only disrupts the formatting of the document but also produces inaccurate translation results, which is irresponsible behavior within the community. For instance, characters such as `（` and `(`, `。` and `.` are distinct and should be treated differently. Additionally, there are issues of Chinese Pinyin, as pointed out by @mxsm.
I appreciate your contributions here, and you are always welcome to contribute. However, I suggest that you first familiarize yourself with the target language before engaging in translation work. This will be more helpful for you in the long run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on code in PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#discussion_r1257328116
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（出口商）
Review Comment:
Can you please elobrate this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#issuecomment-1627608254
Thank You @Pil0tXia for the guidance. From now onwards I'll make sure to get familiar with a language and then start contributing. This was really helpful.
Thanks once gain for helping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mxsm commented on a diff in pull request #3456: Update 07-tracing.md
Posted by "mxsm (via GitHub)" <gi...@apache.org>.
mxsm commented on code in PR #3456:
URL: https://github.com/apache/incubator-eventmesh/pull/3456#discussion_r1137979290
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（出口商）
+ .setMaxExportBatchSize(512) // 设置要使用的最大批量大小
+ .setMaxQueueSize(2048) // 设置队列大小。 这必须 >= 导出批量大小
+ .setExporterTimeout(
+ 30, TimeUnit.SECONDS) // 设置导出在获取之前可以运行的最长时间
+ // 中断
+ .setScheduleDelay(5, TimeUnit.SECONDS) // 设置两次不同导出之间的时间
+ 。建造（）;
OpenTelemetrySdk.builder()
- .setTracerProvider(
- SdkTracerProvider.builder().addSpanProcessor(batchSpansProcessor).build())
- .build();
-```
-
-1. 当使用`EventMeshHTTPServer`类的`init()`方法时，类`AbstractHTTPServer`将获取跟踪器。
-
-```java
+ .setTracerProvider(
+ SdkTracerProvider.builder().addSpanProcessor(batchSpansProcessor).build())
+ 。建造（）;
+当使用“EventMeshHTTPServer”类的“init()”方法时，“AbstractHTTPServer”类将获取跟踪器
super.openTelemetryTraceFactory = new OpenTelemetryTraceFactory(eventMeshHttpConfiguration);
super.tracer = openTelemetryTraceFactory.getTracer(this.getClass().toString());
super.textMapPropagator = openTelemetryTraceFactory.getTextMapPropagator();
-```
-
-2. 然后，在类`AbstractHTTPServer`中的跟踪将起作用。
-
-## 问题
+那么“AbstractHTTPServer”类中的跟踪将起作用。
+问题
+如何在“OpenTelemetryTraceFactory”类中设置不同的导出器？ （解决了）
+从属性中获取导出器类型后，如何处理它。
-### 如何在类“OpenTelemetryTraceFactory”中设置不同的导出器？（已解决）
+'logExporter' 只需要更新它。
-在从属性中获取导出器类型之后，如何处理它。
+但是“zipkinExporter”需要新建并使用“getZipkinExporter()”方法。
-`logExporter`只需要创建新实例即可。
-
-但是，“zipkinExporter”需要新建并使用“getZipkinExporter()”方法。
-
-## 解决方案
-
-### 不同导出器的解决方案
-
-使用反射获取导出器。
+解决方案
+不同出口商的解决方案
+使用反射来获取导出器。
首先，不同的导出器必须实现接口“EventMeshExporter”。
-然后，我们从配置中获取导出器名称，并反射到该类。
+然后我们从配置中获取导出器名称并反映到类中。
-```java
-//different spanExporter
+//不同的spanExporter
String exporterName = configuration.eventMeshTraceExporterType;
-//use reflection to get spanExporter
+//使用反射获取spanExporter
String className = String.format("org.apache.eventmesh.runtime.exporter.%sExporter",exporterName);
EventMeshExporter eventMeshExporter = (EventMeshExporter) Class.forName(className).newInstance();
-spanExporter = eventMeshExporter.getSpanExporter(configuration);
-```
-
-另外，这将包含try catch。如果无法成功获取指定的导出器，则将使用默认的日志导出器。
-
-#### 不同导出器的改进
+spanExporter = eventMeshExporter.getSpanExporter(配置);
+另外，这将用try catch包围。如果无法成功获取指定的exporter，将使用默认的exporter日志代替
+改进不同的出口商
SPI（待完成）
-## 附录
+附录
+参考
+https://github.com/open-telemetry/docs-cn/blob/main/QUICKSTART.md
-### 参考资料
+https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/netty
+Fēnbù shì zhuīzōng
+OpenTelemetry gàishù
+OpenTelemetry shì gōngjù,API hé SDK de jíhé. Nín kěyǐ shǐyòng tā lái jiǎncè, shēngchéng, shōují hé dǎochū yáocè shùjù (zhǐbiāo, rìzhì hé gēnzōng) yǐ jìn háng fēnxī, yǐbiàn liǎojiě nín de ruǎnjiàn dì xìngnéng hé xíngwéi.
-- <https://github.com/open-telemetry/docs-cn/blob/main/QUICKSTART.md>
+Yāoqiú
+shèzhì shì zōng jì
+bùtóng de chūkǒu shāng
+fúwùqì zhōng de kāishǐ hé jiéshù kuàdù
+shèjì xìjié
+SpanProcessor:BatchSpanProcessor
-- <https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/netty>
+dǎochū qì: Rìzhì (mòrèn), jiāng cóng shǔxìng zhòng gēnggǎi
+
+// pèizhì pī chǔlǐ kuàdù chǔlǐ qì. Cǐ kuàdù chǔlǐ qì pīliàng dǎochū kuàdù.
+BatchSpanProcessor batchSpansProcessor =
+ BatchSpanProcessor.Builder(chūkǒu shāng)
+ .SetMaxExportBatchSize(512)// shèzhì yào shǐyòng de zuìdà pīliàng dàxiǎo
+ .SetMaxQueueSize(2048)// shèzhì duìliè dàxiǎo. Zhè bìxū >= dǎochū pīliàng dàxiǎo
+ .SetExporterTimeout(
+ 30, TimeUnit.SECONDS)// shèzhì dǎochū zài huòqǔ zhīqián kěyǐ yùnxíng de zuì cháng shíjiān
+ // zhōngduàn
+ .SetScheduleDelay(5, TimeUnit.SECONDS)// shèzhì liǎng cì bùtóng dǎochū zhī jiān de shíjiān
+ . Jiànzào ();
+OpenTelemetrySdk.Builder()
+ .SetTracerProvider(
+ SdkTracerProvider.Builder().AddSpanProcessor(batchSpansProcessor).Build())
+ . Jiànzào ();
+dāng shǐyòng “EventMeshHTTPServer” lèi de “init()” fāngfǎ shí,“AbstractHTTPServer” lèi jiāng huòqǔ gēnzōng qì
+super.OpenTelemetryTraceFactory = new OpenTelemetryTraceFactory(eventMeshHttpConfiguration);
+super.Tracer = openTelemetryTraceFactory.GetTracer(this.GetClass().ToString());
+super.TextMapPropagator = openTelemetryTraceFactory.GetTextMapPropagator();
+nàme “AbstractHTTPServer” lèi zhōng de gēnzōng jiāng qǐ zuòyòng.
+Wèntí
+rúhé zài “OpenTelemetryTraceFactory” lèi zhōng shèzhì bùtóng de dǎochū qì? (Jiějuéle)
+cóng shǔxìng zhòng huòqǔ dǎochū qì lèixíng hòu, rúhé chǔlǐ tā.
+
Review Comment:
There are some problems here. Please check it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] hanshal101 commented on pull request #3456: Update 07-tracing.md
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on PR #3456:
URL: https://github.com/apache/incubator-eventmesh/pull/3456#issuecomment-1471690311
Can you please assign me this task it would be great. I'll try to complete the remaining tasks soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on code in PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#discussion_r1257279216
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（出口商）
+ .setMaxExportBatchSize(512) // 设置要使用的最大批量大小
+ .setMaxQueueSize(2048) // 设置队列大小。 这必须 >= 导出批量大小
+ .setExporterTimeout(
+ 30, TimeUnit.SECONDS) // 设置导出在获取之前可以运行的最长时间
+ // 中断
+ .setScheduleDelay(5, TimeUnit.SECONDS) // 设置两次不同导出之间的时间
+ 。建造（）;
Review Comment:
Please notice code block translation mistake.
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（出口商）
Review Comment:
Code Block translation mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 closed pull request #3456: Update 07-tracing.md
URL: https://github.com/apache/eventmesh/pull/3456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #3456: Update 07-tracing.md
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #3456:
URL: https://github.com/apache/incubator-eventmesh/pull/3456#issuecomment-1470436633
## [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/3456?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3456](https://codecov.io/gh/apache/incubator-eventmesh/pull/3456?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e3d4d68) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/5352c59c94dba83bad5e75101d1accbcc2f08620?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5352c59) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head e3d4d68 differs from pull request most recent head cd9d3db. Consider uploading reports for the commit cd9d3db to get more accurate results
```diff
@@ Coverage Diff @@
## master #3456 +/- ##
============================================
+ Coverage 14.23% 14.25% +0.01%
- Complexity 1474 1478 +4
============================================
Files 651 651
Lines 31708 31704 -4
Branches 3035 3033 -2
============================================
+ Hits 4514 4518 +4
+ Misses 26803 26793 -10
- Partials 391 393 +2
```
[see 9 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-eventmesh/pull/3456/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#issuecomment-1627464865
I'm really sorry I couldn't make the PR better as I'm a newbie for open-source contributions. Please guide me through on making a good PR. It would be really helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "Pil0tXia (via GitHub)" <gi...@apache.org>.
Pil0tXia commented on PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#issuecomment-1627635027
The EventMesh documentation has been extracted to the [eventmesh-site](https://github.com/apache/eventmesh-site) repository, where you can continue when you are ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#issuecomment-1627718143
Ok Thanks once again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#issuecomment-1627609720
For now should I close the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on code in PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#discussion_r1257328652
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（出口商）
+ .setMaxExportBatchSize(512) // 设置要使用的最大批量大小
+ .setMaxQueueSize(2048) // 设置队列大小。 这必须 >= 导出批量大小
+ .setExporterTimeout(
+ 30, TimeUnit.SECONDS) // 设置导出在获取之前可以运行的最长时间
+ // 中断
+ .setScheduleDelay(5, TimeUnit.SECONDS) // 设置两次不同导出之间的时间
+ 。build（）;
Review Comment:
I have made changes on the 23 line please review it
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（出口商）
+ .setMaxExportBatchSize(512) // 设置要使用的最大批量大小
+ .setMaxQueueSize(2048) // 设置队列大小。 这必须 >= 导出批量大小
+ .setExporterTimeout(
+ 30, TimeUnit.SECONDS) // 设置导出在获取之前可以运行的最长时间
+ // 中断
+ .setScheduleDelay(5, TimeUnit.SECONDS) // 设置两次不同导出之间的时间
+ 。建造（）;
Review Comment:
I have made changes please review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
Re: [PR] Update 07-tracing.md (eventmesh)
Posted by "hanshal101 (via GitHub)" <gi...@apache.org>.
hanshal101 commented on code in PR #3456:
URL: https://github.com/apache/eventmesh/pull/3456#discussion_r1257330506
##########
docs/zh/design-document/07-tracing.md:
##########
@@ -1,87 +1,128 @@
-# 分布式追踪
+分布式追踪
+OpenTelemetry 概述
+OpenTelemetry 是工具、API 和 SDK 的集合。 您可以使用它来检测、生成、收集和导出遥测数据（指标、日志和跟踪）以进行分析，以便了解您的软件的性能和行为。
-## OpenTelemetry概述
+要求
+设置示踪剂
+不同的出口商
+服务器中的开始和结束跨度
+设计细节
+SpanProcessor：BatchSpanProcessor
-OpenTelemetry是一组API和SDK的工具，您可以使用它来仪器化、生成、收集和导出遥测数据（指标、日志和追踪），以便进行分析，以了解您的软件性能和行为。
+导出器：日志（默认），将从属性中更改
-## 需求
-
-- 设置追踪器
-- 不同的导出器
-- 在服务器中开始和结束跨度
-
-## 设计细节
-
-- 跨度处理器：BatchSpanProcessor
-
-- 导出器：默认为日志，可以从属性中更改
-
-```java
-// Configure the batch spans processor. This span processor exports span in batches.
+// 配置批处理跨度处理器。 此跨度处理器批量导出跨度。
BatchSpanProcessor batchSpansProcessor =
- BatchSpanProcessor.builder(exporter)
- .setMaxExportBatchSize(512) // set the maximum batch size to use
- .setMaxQueueSize(2048) // set the queue size. This must be >= the export batch size
- .setExporterTimeout(
- 30, TimeUnit.SECONDS) // set the max amount of time an export can run before getting
- // interrupted
- .setScheduleDelay(5, TimeUnit.SECONDS) // set time between two different exports
- .build();
+ BatchSpanProcessor.builder（exporter）
Review Comment:
Made changes in line 16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org