You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by ah...@apache.org on 2022/04/12 07:01:42 UTC
[isis] branch master updated: ISIS-2445: remove jacoco.skip from scripts
This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new 4af9ff10f3 ISIS-2445: remove jacoco.skip from scripts
4af9ff10f3 is described below
commit 4af9ff10f3606ad47966e99cbc06473d2a1335a7
Author: Andi Huber <ah...@apache.org>
AuthorDate: Tue Apr 12 09:01:37 2022 +0200
ISIS-2445: remove jacoco.skip from scripts
- no longer required, as jacoco needs to be explicitly activated via
profile
---
.github/workflows/ci-build-artifacts-no-push-maven.yml | 2 --
.github/workflows/ci-build-artifacts-push-maven.yml | 2 --
scripts/ci/dry-run.sh | 2 --
3 files changed, 6 deletions(-)
diff --git a/.github/workflows/ci-build-artifacts-no-push-maven.yml b/.github/workflows/ci-build-artifacts-no-push-maven.yml
index 842574acc4..d00f4a0556 100644
--- a/.github/workflows/ci-build-artifacts-no-push-maven.yml
+++ b/.github/workflows/ci-build-artifacts-no-push-maven.yml
@@ -74,14 +74,12 @@ jobs:
# -Dmodule-all-except-incubator ... build all modules except 'incubator' (eg. when vaadin build fails)
# -Denforcer.failFast=true ... fail fast on convergence issues (enforcer plugin)
# -Dmaven.source.skip=true ... no need for the CI build to pull sources
- # -Djacoco.skip=true ... no need for the CI build to add test coverage reports
# -T 1C ... 1 build thread per core
MVN_ADDITIONAL_OPTS: >-
-Dmodule-all
-Dproject.build.outputTimestamp=1
-Dmaven.source.skip=true
-Denforcer.failFast=true
- -Djacoco.skip=true
# FOR DEBUG USE
# - name: Dump GitHub context
diff --git a/.github/workflows/ci-build-artifacts-push-maven.yml b/.github/workflows/ci-build-artifacts-push-maven.yml
index 8cce050643..ef25f77753 100644
--- a/.github/workflows/ci-build-artifacts-push-maven.yml
+++ b/.github/workflows/ci-build-artifacts-push-maven.yml
@@ -79,13 +79,11 @@ jobs:
env:
# -Dgithub ... build only the released modules and deploy to github pakages
# -Denforcer.failFast=true ... fail fast on convergence issues (enforcer plugin)
- # -Djacoco.skip=true ... no need for the CI build to add test coverage reports
# -T 1C ... 1 build thread per core
MVN_ADDITIONAL_OPTS: >-
-f isis-parent/pom.xml
-Dgithub
-Denforcer.failFast=true
- -Djacoco.skip=true
-DinstallAtEnd=true -DdeployAtEnd=true
GITHUB_TOKEN: ${{ github.token }}
MVN_STAGES: deploy
diff --git a/scripts/ci/dry-run.sh b/scripts/ci/dry-run.sh
index 238419a186..5edb5b342c 100644
--- a/scripts/ci/dry-run.sh
+++ b/scripts/ci/dry-run.sh
@@ -60,7 +60,6 @@ export SOURCE_MODE=attach
# -Dmodule-all ... build all modules
# -Denforcer.failFast=true ... fail fast on convergence issues (enforcer plugin)
-# -Djacoco.skip=true ... no need for the CI build to add test coverage reports
# -T 1C ... 1 build thread per core
export MVN_ADDITIONAL_OPTS="\
-Dmodule-examples-demo-wicket \
@@ -68,7 +67,6 @@ export MVN_ADDITIONAL_OPTS="\
-Djacoco-report-xml \
-Dskip-docker=true \
-Denforcer.failFast=true \
--Djacoco.skip=false \
-DskipTests=false"
# possible modes are