[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #657: vm wizard: add MAC Address validator

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #657:
URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r484653718



##########
File path: src/views/compute/wizard/NetworkConfiguration.vue
##########
@@ -26,16 +26,40 @@
     :scroll="{ y: 225 }"
   >
     <template slot="ipAddress" slot-scope="text, record">
-      <a-input
-        style="width: 150px;"
-        :placeholder="$t('label.ipaddress')"
-        @change="($event) => updateNetworkData('ipAddress', record.id, $event.target.value)" />
+      <a-form-item>
+        <a-input
+          style="width: 150px;"
+          v-decorator="['ipAddress' + record.id, {
+            rules: [{
+              validator: validatorIpAddress,
+              cidr: record.cidr,
+              networkType: record.type
+            }]
+          }]"

Review comment:
       @utchoang Could you add a placeholder in the ipaddress input with the cidr ?
   Also could you add the cidr in the expanded row render of the network ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org