You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2021/03/17 13:04:06 UTC
[GitHub] [bigtop] elukey opened a new pull request #760: BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files
elukey opened a new pull request #760:
URL: https://github.com/apache/bigtop/pull/760
According to
https://lintian.debian.org/tags/debian-rules-calls-pwd.html,
CURDIR is the preferred way in a makefile (like rules) to refer to the
current directory. For some reason I got building failures when running
a Debian 10 bigtop docker imagei and trying to build the hadoop pkg,
that got solved only applying this fix.
Applied the same fix to all the debian rules files with ${PWD}.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #760: BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #760:
URL: https://github.com/apache/bigtop/pull/760#issuecomment-801187300
@sekikn thanks for the feedback! Testing now with ${CURDIR}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #760: BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files
Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #760:
URL: https://github.com/apache/bigtop/pull/760#issuecomment-801140257
Thanks for the PR @elukey! It worked with GPDB and Hadoop, but it didn't with Phoenix in my environment (Ubuntu 20.04). The error was as follows:
```
$ ./gradlew phoenix-clean phoenix-pkg
...
bash -x debian/install_phoenix.sh \
--build-dir=${CURDIR}/build \
--prefix=debian/tmp
+ set -ex
++ getopt -n debian/install_phoenix.sh -o '' -l prefix: -l doc-dir: -l lib-dir: -l installed-lib-dir: -l bin-dir: -l examples-dir: -l conf-dir: -l build-dir: -- --build-dir=/build --prefix=debian/tmp
+ OPTS=' --build-dir '\''/build'\'' --prefix '\''debian/tmp'\'' --'
+ '[' 0 '!=' 0 ']'
+ eval set -- ' --build-dir '\''/build'\'' --prefix '\''debian/tmp'\'' --'
++ set -- --build-dir /build --prefix debian/tmp --
+ true
+ case "$1" in
+ BUILD_DIR=/build
...
+ for var in PREFIX BUILD_DIR
++ eval 'echo $PREFIX'
+++ echo debian/tmp
+ '[' -z debian/tmp ']'
+ for var in PREFIX BUILD_DIR
++ eval 'echo $BUILD_DIR'
+++ echo /build
+ '[' -z /build ']'
+ MAN_DIR=/usr/share/man/man1
+ DOC_DIR=/usr/share/doc/phoenix
+ LIB_DIR=/usr/lib/phoenix
+ BIN_DIR=/usr/lib/phoenix/bin
+ ETC_DIR=/etc/phoenix
+ CONF_DIR=/etc/phoenix/conf.dist
+ install -d -m 0755 debian/tmp//usr/lib/phoenix/bin
+ install -d -m 0755 debian/tmp//usr/lib/phoenix
+ install -d -m 0755 debian/tmp//usr/lib/phoenix/lib
+ install -d -m 0755 debian/tmp//usr/share/doc/phoenix
+ install -d -m 0755 debian/tmp//usr/share/man/man1
+ install -d -m 0755 debian/tmp//etc/phoenix
+ install -d -m 0755 debian/tmp//etc/phoenix/conf.dist
+ install -d -m 0755 debian/tmp/var/lib/phoenix
+ install -d -m 0755 debian/tmp/var/log/phoenix
+ cp '/build/*.jar' debian/tmp//usr/lib/phoenix/
cp: cannot stat '/build/*.jar': No such file or directory
make[1]: *** [debian/rules:43: override_dh_auto_install] Error 1
make[1]: Leaving directory '/home/vagrant/bigtop/output/phoenix/phoenix-5.1.0'
make: *** [debian/rules:35: binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2
debuild: fatal error at line 1182:
dpkg-buildpackage -us -uc -ui -b
failed
> Task :phoenix-deb FAILED
FAILURE: Build failed with an exception.
```
Maybe we should use `${CURDIR}` instead of `$${CURDIR}`? (though I'm not sure why `$${PWD}` worked... :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] elukey commented on pull request #760: BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files
Posted by GitBox <gi...@apache.org>.
elukey commented on pull request #760:
URL: https://github.com/apache/bigtop/pull/760#issuecomment-801200699
@sekikn seems to work!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn merged pull request #760: BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files
Posted by GitBox <gi...@apache.org>.
sekikn merged pull request #760:
URL: https://github.com/apache/bigtop/pull/760
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #760: BIGTOP-3527: replace ${PWD} with ${CURDIR} in debian rules files
Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #760:
URL: https://github.com/apache/bigtop/pull/760#issuecomment-801509193
+1, Thanks for fixing this @elukey!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org