[jira] [Commented] (HDFS-6030) to remove a redundant/unused constructor in INode.java

["Yongjun Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-6030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915273#comment-13915273 ] 

Yongjun Zhang commented on HDFS-6030:
-------------------------------------

Uploaded a patch to remove the constructor. Thanks for reviewing.




> to remove a redundant/unused constructor in INode.java
> ------------------------------------------------------
>
>                 Key: HDFS-6030
>                 URL: https://issues.apache.org/jira/browse/HDFS-6030
>             Project: Hadoop HDFS
>          Issue Type: Task
>    Affects Versions: 2.3.0
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>            Priority: Trivial
>         Attachments: HDFS-6030.001.patch
>
>
> When I look at fix of HDFS-4879, I noticed that class BlocksMapUpdateInfo in INode.java,  has a constructor that still uses ArrayList<Block> (which HDFS-4879 tries to replace with ChunkedArrayList for better memory efficiency)
> {code}
>     public static class BlocksMapUpdateInfo { 
>     ...... 
>     public BlocksMapUpdateInfo(List<Block> toDeleteList) {
>       this.toDeleteList = toDeleteList == null ? new ArrayList<Block>()
>           : toDeleteList;
>     }
>     ......
>     }
> {code}
> It turns out that this constructor is not used anywhere. I'm filing this JIRA to remove it.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)